Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The _helper_ bindCallback should probably be removed #889

Closed
benlesh opened this issue Dec 4, 2015 · 3 comments
Closed

The _helper_ bindCallback should probably be removed #889

benlesh opened this issue Dec 4, 2015 · 3 comments
Assignees
Labels
help wanted Issues we wouldn't mind assistance with.
Milestone

Comments

@benlesh
Copy link
Member

benlesh commented Dec 4, 2015

On operators with thisArg, we're using a util/helper called bindCallback. It has two problems:

  1. it introduces a closure, which we're actively trying to avoid.
  2. it's got the same name as the bindCallback method (formerly fromCallback).

Solution:

I think we should remove this everywhere and just use apply or call where appropriate.

@benlesh benlesh added the help wanted Issues we wouldn't mind assistance with. label Dec 4, 2015
@kwonoj
Copy link
Member

kwonoj commented Dec 4, 2015

So for some of operator still has thisArg (in #878) will directly apply context instead of using bindCallback?

@benlesh benlesh added this to the Post-Beta milestone Dec 4, 2015
@benlesh
Copy link
Member Author

benlesh commented Dec 4, 2015

right... if you still need to have thisArg, it should just use apply or call directly.

@benlesh benlesh self-assigned this Dec 8, 2015
@benlesh benlesh closed this as completed in f647eb6 Dec 9, 2015
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Development

No branches or pull requests

2 participants