refactor(KitchenSink): remove thisArg from distinctUntilChanged signature

[staltz]

Remove an obsolete thisArg from the signature of distinctUntilChanged in KitchenSink file.

For issue #878.

[kwonoj]

think commit message need to updated to distinctUntilKeyChanged

[kwonoj]

• requires to update implementation of distinctUntilKeyChanged,

if (compare) {
      return compare.call(thisArg, x[key], y[key]);
    }
...

[staltz]

Ouch, I didn't notice it was distinctUntilKeyChanged, not distinctUntilChanged.

[kwonoj]

@Blesh Actually this need to be merged to close out #878 completely - I'll check in once PR's updated to include changes.

[benlesh]

Merged with 58c4ea9. Thanks @staltz

[kwonoj]

@Blesh , is this PR updated? I thought @staltz might need update to correctly reflect distinctUntilKeyChanged.

[benlesh]

I thought it was.

[benlesh]

I reviewed it and I thought it was supposed to be distinctUntilChanged. Confused by the title, I guess.

[benlesh]

Looks correct to me: staltz@7cc3cbd#diff-e14b61d383aecb7508d52902e077098dL11

Is it just the PR title that was wrong?

[kwonoj]

I thought it was supposed to be distinctUntilChanged

: @staltz did also :) distinctUntilChanged is already in place, and this PR is about distinctUntilKeyChanged. and for distinctUntilKeyChanged, implementation still have pieces of using thisArg so PR might need to contains those changes to completely get away from thisArg for this operator.

[kwonoj]

This comment #993 (comment) is piece pointing implementation of distinctUntilKeyChanged .

[kwonoj]

Anyway, since this PR's already landed separate PR could be created to close distinctUntilKeyChanged.