EmptyObserver and TestObserver #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It creates no value and confuses with Observers.empty() which throws an OnErrorNotImplementedException if onError is invoked. Fixes ReactiveX#1741
It throws an Exception ... and now EmptyObserver is gone.
If a delegate is not provided then do nothing. Fixes ReactiveX#1571
benjchristensen
added a commit
that referenced
this pull request
Oct 10, 2014
EmptyObserver and TestObserver
| @@ -96,7 +92,7 @@ public void call(final Subscriber<? super T> s) { | |||
| s.add(Subscriptions.create(new Action0() { | |||
| @Override | |||
| public void call() { | |||
| state.observerRef = EMPTY_OBSERVER; | |||
| state.observerRef = Observers.empty(); | |||
There was a problem hiding this comment.
Should not use Observers.empty() here. Once it's unsubscribed, onError should be ignored, but Observers.empty() will throw an Exception for onError. Why not put EmptyObserver into an internal package?
There was a problem hiding this comment.
We could, or just create a static inner class here as it's rare this is needed.
Thanks for catching this. I'll fix this shortly.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmptyObserveras it was confusing compared toObservers.empty()(fixes Observer.empty() vs EmptyObserver #1741)TestObservernot throwOnErrorNotImplementedif a delegate is not provided (fixes TestObserver always delegates to EMPTY, throws exception #1571)