Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc of empty() method at Subscribers class still mentions EmptyObserver #3664

Closed
fcduarte opened this issue Feb 3, 2016 · 7 comments
Closed

Comments

@fcduarte
Copy link

fcduarte commented Feb 3, 2016

EmptyObserver was removed on #1742 but empty() method at Subscribers class still mentions it:

    /**
     * Returns an inert {@link Subscriber} that does nothing in response to the emissions or notifications from
     * any {@code Observable} it subscribes to. This is different, however, from an {@code EmptyObserver}, in
     * that it will throw an exception if its {@link Subscriber#onError onError} method is called (whereas
     * {@code EmptyObserver} will swallow the error in such a case).
     *
     * @return an inert {@code Observer}
     */

If I had a good description change for that I'd create a PR but since I don't have I created this issue :)

Thanks,

@digitalbuddha
Copy link

how about

/**
     * Returns an inert {@link Subscriber} that does nothing in response to the emissions or notifications from
     * any {@code Observable} it subscribes to.  Will throw an exception if {@link Subscriber#onError onError} method is called
     *
     * @return an inert {@code Observer}
     */

@fcduarte
Copy link
Author

fcduarte commented Feb 3, 2016

👍

@digitalbuddha
Copy link

opening pr or should I?

@fcduarte
Copy link
Author

fcduarte commented Feb 3, 2016

I will. Just need to finish some work stuff.

On Tue, Feb 2, 2016 at 5:43 PM Mike Nakhimovich notifications@github.com
wrote:

opening pr or should I?


Reply to this email directly or view it on GitHub
#3664 (comment).

@digitalbuddha
Copy link

already opened, I was looking for my first pr to this project :-)

@fcduarte
Copy link
Author

fcduarte commented Feb 3, 2016

no problem :)

@akarnokd
Copy link
Member

akarnokd commented Feb 9, 2016

Closing via #3665.

@akarnokd akarnokd closed this as completed Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants