Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmptyObserver and TestObserver #1742

Merged
merged 3 commits into from
Oct 10, 2014
Merged

EmptyObserver and TestObserver #1742

merged 3 commits into from
Oct 10, 2014

Commits on Oct 10, 2014

  1. Delete EmptyObserver 

    It creates no value and confuses with Observers.empty() which throws an OnErrorNotImplementedException if onError is invoked.
Fixes ReactiveX#1741
    @benjchristensen
    benjchristensen committed Oct 10, 2014
    Configuration menu
    Copy the full SHA
    00e4a63 View commit details
    Browse the repository at this point in the history

  2. Clarify Javadoc on Observers.empty() 

    It throws an Exception ... and now EmptyObserver is gone.
    @benjchristensen
    benjchristensen committed Oct 10, 2014
    Configuration menu
    Copy the full SHA
    f3d2945 View commit details
    Browse the repository at this point in the history

  3. Swallow Errors in TestObserver 

    If a delegate is not provided then do nothing.
Fixes ReactiveX#1571
    @benjchristensen
    benjchristensen committed Oct 10, 2014
    Configuration menu
    Copy the full SHA
    35c4fa1 View commit details
    Browse the repository at this point in the history