Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3051 Fix dtype issue in Spacing transform #3052

Merged
merged 7 commits into from
Sep 30, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Sep 30, 2021

Fixes #3051 .

Description

This PR fixed the output data type issue of Spacing transform.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Sep 30, 2021

/black

@madil90
Copy link
Contributor

madil90 commented Sep 30, 2021

/build

5 similar comments
@madil90
Copy link
Contributor

madil90 commented Sep 30, 2021

/build

@madil90
Copy link
Contributor

madil90 commented Sep 30, 2021

/build

@madil90
Copy link
Contributor

madil90 commented Sep 30, 2021

/build

@madil90
Copy link
Contributor

madil90 commented Sep 30, 2021

/build

@madil90
Copy link
Contributor

madil90 commented Sep 30, 2021

/build

@Nic-Ma Nic-Ma requested review from rijobro, wyli and ericspod September 30, 2021 05:45
@madil90
Copy link
Contributor

madil90 commented Sep 30, 2021

/build

@rijobro
Copy link
Contributor

rijobro commented Sep 30, 2021

So the purpose of _dtype is to convert the image to that type before the interpolation, and then to convert back to float afterwards?

Edit: I just checked the linked issue and think this is the case. Thanks for the quick PR.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Sep 30, 2021

So the purpose of _dtype is to convert the image to that type before the interpolation, and then to convert back to float afterwards?

Edit: I just checked the linked issue and think this is the case. Thanks for the quick PR.

Yes, it's just used to adjust the interpolation computation.

Thanks for your review.

@Nic-Ma Nic-Ma enabled auto-merge (squash) September 30, 2021 14:03
@Nic-Ma Nic-Ma merged commit d15cedd into Project-MONAI:dev Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacing transform outputs float64 Tensor data
3 participants