New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacing transform outputs float64 Tensor data #3051

Closed

Nic-Ma opened this issue Sep 30, 2021 · 0 comments · Fixed by #3052

Assignees

Labels

bug

Milestone

Bug Fixes or Misc...

Contributor

Nic-Ma commented Sep 30, 2021 •

edited

Loading

Describe the bug
The PR #3045 introduced an issue that it converted the output data dytpe to the computation dtype, actually it should always output float32:
https://github.com/Project-MONAI/MONAI/blob/0.7.0/monai/transforms/spatial/array.py#L127
And I think no need to deepcopy the image:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/transforms/spatial/array.py#L203

Nic-Ma self-assigned this

Nic-Ma added the bug label

Nic-Ma added this to the Bug Fixes or Misc improvements milestone

Nic-Ma mentioned this issue

3051 Fix dtype issue in Spacing transform #3052

Merged

7 tasks

Nic-Ma closed this as completed in #3052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment