Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes from 6.x branch to dev #1048

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

Quetzacoalt91
Copy link
Member

Questions Answers
Description? Cherry pick of #1009 and #1035
Type? improvement
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
Sponsor company /
How to test? See related line in PRs

@Hlavtox
Copy link
Contributor

Hlavtox commented Nov 28, 2024

@Quetzacoalt91 Thomas, could you also check vice versa? Do we have any changes that need backport dev > 6?

@Quetzacoalt91
Copy link
Member Author

We deal mostly with improvements and the Update Assistant v7 will be released before PrestaShop v9, so at the moment I don't see any PR in particular to send on the branch 6.x.

@Hlavtox
Copy link
Contributor

Hlavtox commented Nov 28, 2024

@Quetzacoalt91 In that case, no need, if v7 will be ready. :-)

Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Quetzacoalt91

Thank you for your PR, I tested it and it seems to works as you can see :

image

image

Because the PR seems to works as expected, It's QA ✔️

Thank you

@ga-devfront ga-devfront merged commit 73065f0 into PrestaShop:dev Dec 3, 2024
33 checks passed
@ps-jarvis
Copy link
Collaborator

PR merged, well done!

Message to @PrestaShop/committers: do not forget to milestone it before the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants