Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to recent PRs #1009

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Adapt to recent PRs #1009

merged 1 commit into from
Nov 18, 2024

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Nov 14, 2024 •
edited
Loading

Questions Answers
Description? Autoupgrade PR for recent PRs - PrestaShop/PrestaShop#37236 and PrestaShop/PrestaShop#36873 and added a comment about PrestaShop/PrestaShop#35843 (in dev branch)
Type?
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company
How to test?

How to test

  • Upgrade from 8.1 to 9.0
  • Open phpmyadmin
  • See that:
    • A) meta_keywords columns is removed from all tables.
    • B) There is PS_DEFAULT_LANGUAGE_URL_PREFIX record in ps_configuration.
    • C) There is PS_SEPARATOR_FILE_MANAGER_SQL record in ps_configuration.
  • No need to test anything else, not in the scope of this PR

This was referenced Nov 14, 2024
Merged
Merged
Merged
@M0rgan01 M0rgan01 modified the milestones: 6.6.0, 6.3.0 Nov 14, 2024
@M0rgan01
Copy link
Contributor

@Hlavtox PR #1010 will fix CI

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 14, 2024

@M0rgan01 Ok I will rebase after it's merged. :-)

@Hlavtox Hlavtox added Blocked Status: The issue is blocked by another task Waiting for rebase and removed waiting for QA labels Nov 14, 2024
@Hlavtox Hlavtox added waiting for QA and removed Blocked Status: The issue is blocked by another task Waiting for rebase labels Nov 14, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 14, 2024

@M0rgan01 Ready to go, tests should be green. :-)

@AureRita
Copy link
Contributor

Hi @Hlavtox

Your Pr is currently in conflict, maybe because this PR was merged,
you can see the conflict here :

image

Waiting for feedback

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 18, 2024

@AureRita You are rebasing to wrong branch, this PR targets 6.x

@AureRita
Copy link
Contributor

Yes Indeed, sorry didn't see that this parameter change

AureRita
AureRita approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hlavtox

Thank you for your PR, I tested it and it seems to works as you can see :

recording.335.webm

Tested from :
8.2 to 9.0.0
8.0.4 to 9.0.0

Because the PR seems to works as expected, It's QA ✔️

Thank you

@Quetzacoalt91 Quetzacoalt91 merged commit 4ea36f0 into PrestaShop:6.x Nov 18, 2024
35 checks passed
@Quetzacoalt91 Quetzacoalt91 mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AureRita AureRita AureRita approved these changes

@ga-devfront ga-devfront ga-devfront approved these changes

@M0rgan01 M0rgan01 M0rgan01 approved these changes

Assignees
No one assigned
Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Hlavtox @M0rgan01 @AureRita @ga-devfront @Quetzacoalt91 @ps-jarvis