Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoupgrade PR for 37261 #1035

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Autoupgrade PR for 37261 #1035

merged 1 commit into from
Nov 25, 2024

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Nov 23, 2024

Questions Answers
Description? Adds new configuration value for PrestaShop/PrestaShop#37261
Type?
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company
How to test? Upgrade to 9.0.0, see that PS_SEARCH_FUZZY_MAX_DIFFERENCE is in ps_configuration table. But I honestly think that automatic tests are sufficient, it's just one of many simmilar lines there.

@Hlavtox Hlavtox mentioned this pull request Nov 23, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@M0rgan01 M0rgan01 modified the milestones: 7.0.0, 6.3.0 Nov 25, 2024
@AureRita AureRita self-assigned this Nov 25, 2024
AureRita
AureRita approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hlavtox

Thank you for your PR, I tested it and it seems to works as you can see :

recording.8.webm

Tested from :
8.0.4 to 8.2
8.2 to 9.0.0
8.0.4 to 9.0.0

Because the PR seems to works as expected, It's QA ✔️

Thank you

@Quetzacoalt91 Quetzacoalt91 merged commit 20e6b51 into PrestaShop:6.x Nov 25, 2024
35 checks passed
@Quetzacoalt91 Quetzacoalt91 mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AureRita AureRita AureRita approved these changes

@ga-devfront ga-devfront ga-devfront approved these changes

@M0rgan01 M0rgan01 M0rgan01 approved these changes

Assignees

@AureRita AureRita

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Hlavtox @M0rgan01 @ga-devfront @AureRita @Quetzacoalt91