This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
FIX use default boto args (use_ssl) for get_client #335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix to the method (introduced in #322) that gets the S3 boto client that sets
use_ssl
to True; the default client uses this setting and it would be best to maintain those default settings.I ran into this because we, by default, reject all bucket traffic that isn't encrypted.
This is small enough and it was minimal effort for me to create this PR (instead of first creating an issue); lemme know if you want an issue first.
Example
Screenshots
Checklist
pre-commit
checks.pre-commit install && pre-commit run --all
locally for formatting and linting.mkdocs serve
view documentation locally.