Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
FIX default boto args
Browse files Browse the repository at this point in the history
  • Loading branch information
ConstantinoSchillebeeckx committed Nov 6, 2023
1 parent 3a5124f commit 333eae0
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
2 changes: 1 addition & 1 deletion prefect_aws/deployments/steps.py
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ def get_s3_client(
aws_client_parameters = credentials.get("aws_client_parameters", client_parameters)
api_version = aws_client_parameters.get("api_version", None)
endpoint_url = aws_client_parameters.get("endpoint_url", None)
use_ssl = aws_client_parameters.get("use_ssl", None)
use_ssl = aws_client_parameters.get("use_ssl", True)
verify = aws_client_parameters.get("verify", None)
config_params = aws_client_parameters.get("config", {})
config = Config(**config_params)
Expand Down
16 changes: 10 additions & 6 deletions tests/deploments/test_steps.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@ def tmp_files(tmp_path: Path):
"testdir2/testfile5.txt",
]

(tmp_path / ".prefectignore").write_text("""
(tmp_path / ".prefectignore").write_text(
"""
testdir1/*
.prefectignore
""")
"""
)

for file in files:
filepath = tmp_path / file
Expand Down Expand Up @@ -228,7 +230,7 @@ def test_s3_session_with_params():
assert {
"api_version": "v1",
"endpoint_url": None,
"use_ssl": None,
"use_ssl": True,
"verify": None,
}.items() <= all_calls[1].kwargs.items()
assert all_calls[1].kwargs.get("config").connect_timeout == 300
Expand All @@ -244,7 +246,7 @@ def test_s3_session_with_params():
assert {
"api_version": None,
"endpoint_url": None,
"use_ssl": None,
"use_ssl": True,
"verify": None,
}.items() <= all_calls[3].kwargs.items()
assert all_calls[3].kwargs.get("config").connect_timeout == 60
Expand Down Expand Up @@ -340,12 +342,14 @@ def test_prefectignore_with_comments_and_empty_lines(
folder = "my-project"

# Update the .prefectignore file with comments and empty lines
(tmp_files / ".prefectignore").write_text("""
(tmp_files / ".prefectignore").write_text(
"""
# This is a comment
testdir1/*
.prefectignore
""")
"""
)

os.chdir(tmp_files)

Expand Down

0 comments on commit 333eae0

Please sign in to comment.