Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

FIX use default boto args (use_ssl) for get_client #335

Closed
wants to merge 1 commit into from
Closed

FIX use default boto args (use_ssl) for get_client #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion prefect_aws/deployments/steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ def get_s3_client(
aws_client_parameters = credentials.get("aws_client_parameters", client_parameters)
api_version = aws_client_parameters.get("api_version", None)
endpoint_url = aws_client_parameters.get("endpoint_url", None)
use_ssl = aws_client_parameters.get("use_ssl", None)
use_ssl = aws_client_parameters.get("use_ssl", True)
verify = aws_client_parameters.get("verify", None)
config_params = aws_client_parameters.get("config", {})
config = Config(**config_params)
Expand Down
4 changes: 2 additions & 2 deletions tests/deploments/test_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def test_s3_session_with_params():
assert {
"api_version": "v1",
"endpoint_url": None,
"use_ssl": None,
"use_ssl": True,
"verify": None,
}.items() <= all_calls[1].kwargs.items()
assert all_calls[1].kwargs.get("config").connect_timeout == 300
Expand All @@ -244,7 +244,7 @@ def test_s3_session_with_params():
assert {
"api_version": None,
"endpoint_url": None,
"use_ssl": None,
"use_ssl": True,
"verify": None,
}.items() <= all_calls[3].kwargs.items()
assert all_calls[3].kwargs.get("config").connect_timeout == 60
Expand Down