Feature/make properties typed #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljeub-pometry
force-pushed
the
feature/MakePropertiesTyped
branch
from
4e2a186 to
5bf3d84
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1266 +/- ##
==========================================
- Coverage 58.02% 58.00% -0.03%
==========================================
Files 173 173
Lines 18562 18776 +214
==========================================
+ Hits 10771 10891 +120
- Misses 7791 7885 +94
☔ View full report in Codecov by Sentry. |
ljeub-pometry
force-pushed
the
feature/MakePropertiesTyped
branch
from
d490a17 to
ff2094a
Compare
* eliminate a lot of arc clones * replace String by ArcStr (wrapped Arc<str>) for cheap clone and to make it possible to support string deduplication * test string deduplication * implement string deduplication for property values * clean up warnings * expose meta data in core ops and minor cleanup
ljeub-pometry
force-pushed
the
feature/MakePropertiesTyped
branch
from
d9aa5c1 to
349da6e
Compare
miratepuffin
approved these changes
Sep 20, 2023
| } | ||
|
|
||
| pub type Key = String; //Fixme: This should really be the internal usize index but that means more reworking of the low-level api | ||
| pub type Key = ArcStr; //Fixme: This should really be the internal usize index but that means more reworking of the low-level api |
There was a problem hiding this comment.
Wanna make a ticket for this so we don't forget
|
|
||
| fn edge_meta(&self) -> &Meta; | ||
|
|
||
| fn graph_meta(&self) -> &GraphProps; |
There was a problem hiding this comment.
Should GraphProps be renamed to GraphMeta?
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
* take property insertion apart and put it back together again * fix tests that were testing broken behaviour * remove `"_id"` from properties and change stray ints to floats in python tests * fix warnings * String deduplication (#1269) * eliminate a lot of arc clones * replace String by ArcStr (wrapped Arc<str>) for cheap clone and to make it possible to support string deduplication * test string deduplication * implement string deduplication for property values * clean up warnings * expose meta data in core ops and minor cleanup * fix rebase issues and clean up warnings * dubious warning fix * attribute does not work, warning is still there * simplify edge addition and deletion * No more spin-locking for adding edges (instead get locks in consistent order)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Issues
If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are
close,closes,closed,fix,fixes,fixed,resolve,resolves,resolved.Please delete this text before creating your PR
Are there any further changes required?