String deduplication #1269
Merged
String deduplication #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke it possible to support string deduplication
ljeub-pometry
requested review from
fabianmurariu,
miratepuffin and
Haaroon
fabianmurariu
approved these changes
Sep 18, 2023
|
I too approve, with large files i have seen a reduction of 15G in ram, a previous file set (netflow and logs on day2) i saw 55G of raphtory ram usage, now with these changes the graph uses 40.7G of ram |
Haaroon
approved these changes
Sep 18, 2023
ljeub-pometry
added a commit
that referenced
this pull request
Sep 20, 2023
* eliminate a lot of arc clones * replace String by ArcStr (wrapped Arc<str>) for cheap clone and to make it possible to support string deduplication * test string deduplication * implement string deduplication for property values * clean up warnings * expose meta data in core ops and minor cleanup
miratepuffin
pushed a commit
that referenced
this pull request
Sep 20, 2023
* take property insertion apart and put it back together again * fix tests that were testing broken behaviour * remove `"_id"` from properties and change stray ints to floats in python tests * fix warnings * String deduplication (#1269) * eliminate a lot of arc clones * replace String by ArcStr (wrapped Arc<str>) for cheap clone and to make it possible to support string deduplication * test string deduplication * implement string deduplication for property values * clean up warnings * expose meta data in core ops and minor cleanup * fix rebase issues and clean up warnings * dubious warning fix * attribute does not work, warning is still there * simplify edge addition and deletion * No more spin-locking for adding edges (instead get locks in consistent order)
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
* take property insertion apart and put it back together again * fix tests that were testing broken behaviour * remove `"_id"` from properties and change stray ints to floats in python tests * fix warnings * String deduplication (#1269) * eliminate a lot of arc clones * replace String by ArcStr (wrapped Arc<str>) for cheap clone and to make it possible to support string deduplication * test string deduplication * implement string deduplication for property values * clean up warnings * expose meta data in core ops and minor cleanup * fix rebase issues and clean up warnings * dubious warning fix * attribute does not work, warning is still there * simplify edge addition and deletion * No more spin-locking for adding edges (instead get locks in consistent order)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change? If yes is this documented?
no, changes are completely transparent to the user-facing apis
How was this patch tested?
existing tests still work and added a test to check the deduplication is effective