Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v0.19.0 release fixes onto master #170

Merged
merged 8 commits into from
Nov 15, 2021
Merged

Merge v0.19.0 release fixes onto master #170

merged 8 commits into from
Nov 15, 2021

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Nov 9, 2021

Context: Bugfixes from v0.19.0 release

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

github-actions bot and others added 6 commits November 3, 2021 14:27
* Added auto version bump functionality to pl lightning (#159)

* Added auto version bump functionality to pl lightning

* Update .github/workflows/pre_release_version_bump.yml

removed trailing white space

* Update .github/workflows/post_release_version_bump.yml

Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>

* Update .github/workflows/pre_release_version_bump.yml

Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>

* removed flag for pennylane release as it is not required

Co-authored-by: antalszava <antalszava@gmail.com>

* Update pre_release_version_bump.yml (#160)

* Update pre_release_version_bump.yml

* Update pre_release_version_bump.yml

* Update pre_release_version_bump.yml

* Update .github/workflows/pre_release_version_bump.yml

* Apply suggestions from code review

* Update post_release_version_bump.yml

swap main --> master

* Update CHANGELOG.md

To be consistent with other plugins and not cause errors for the auto version bumping

* pre release version bump

* updates

* Update pennylane_lightning/_version.py

* formatting updates to changelog

Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@users.noreply.github.com>
* Fix OMP issue on M1 macs

* Update changelog
* Fix OMP issue on M1 macs

* Update changelog

* Fix CI builder
* Fix OMP with ARM MacOS

* Ensure wheels uploaded to GH

* Separate out noarch wheels
@mlxd mlxd changed the title V0.19.0 rc0 Merge v0.19.0 release fixes onto master Nov 9, 2021
@mlxd mlxd requested a review from trbromley November 9, 2021 10:28
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #170 (3a977d9) into master (d3c9495) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #170   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          182       182           
=========================================
  Hits           182       182           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c9495...3a977d9. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021

Test Report (C++) on Ubuntu

       1 files  ±0         1 suites  ±0   0s ⏱️ ±0s
   327 tests ±0     327 ✔️ ±0  0 💤 ±0  0 ±0 
1 185 runs  ±0  1 185 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 3a977d9. ± Comparison against base commit d3c9495.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlxd!

@@ -55,7 +57,7 @@ jobs:
CIBW_ARCHS_LINUX: ${{matrix.arch}}

- uses: actions/upload-artifact@v2
if: github.ref == 'refs/heads/master'
if: ${{ github.event_name == 'release' || github.ref == 'refs/heads/master' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the or here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I think || is supported (link https://docs.github.com/en/actions/learn-github-actions/expressions#operators) though happy to modify if you think or is better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I misunderstood. Yea, we want this to run in both cases. We can issue a release from a non master branch (the tagged v0.xy branch), and ensure the wheels are built. Master may have since move on, so we need to be able to support both ( I think).

on:
release:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the "types" line, as we do e.g. for wheel_linux_ppc64le.yml? (same question applies to some of the other workflows)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I think these need to be added to all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch -- I think these need to be added to all workflows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than changing the RC, maybe we merge this as is and modify in a subsequent PR. This won't change the wheel, and help with consistency across the wheel history. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Thanks @mlxd!

.github/CHANGELOG.md Outdated Show resolved Hide resolved
@mlxd mlxd merged commit 3cc54a3 into master Nov 15, 2021
@mlxd mlxd deleted the v0.19.0-rc0 branch November 15, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants