Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v0.19.0 release fixes onto master #170

Merged
merged 8 commits into from
Nov 15, 2021
Merged

Merge v0.19.0 release fixes onto master #170

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2b15d02
Version Bump `0.19.0` (#163)
github-actions[bot] Nov 3, 2021
6b570ed
Fix OpenMP library issues on M1 Macs (#166)
mlxd Nov 8, 2021
2798d5b
Fix CI builder release issues (#168)
mlxd Nov 8, 2021
983ed03
Trigger CI on release creation
mlxd Nov 8, 2021
73a8f87
CI wheelbuilder updates (#169)
mlxd Nov 9, 2021
5c546ec
Merge branch 'master' into v0.19.0-rc0
mlxd Nov 9, 2021
92844aa
Merge branch 'master' into v0.19.0-rc0
antalszava Nov 10, 2021
3a977d9
Update .github/CHANGELOG.md
antalszava Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions .github/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,29 @@
# Release 0.19.0-dev

### New features since last release
# Release 0.19.0

### Improvements

* The performance of parametric gates has been improved.
[(#157)](https://github.com/PennyLaneAI/pennylane-lightning/pull/157)
[(#157)](https://github.com/PennyLaneAI/pennylane-lightning/pull/157)

* AVX support is enabled for Linux users on Intel/AMD platforms.
[(#157)](https://github.com/PennyLaneAI/pennylane-lightning/pull/157)
[(#157)](https://github.com/PennyLaneAI/pennylane-lightning/pull/157)

* PennyLane-Lightning has been updated to conform with clang-tidy recommendations for modernization, offering performance improvements across all use-cases.
[(#153)](https://github.com/PennyLaneAI/pennylane-lightning/pull/153)

### Documentation
* PennyLane-Lightning has been updated to conform with clang-tidy
recommendations for modernization, offering performance improvements across
all use-cases.
[(#153)](https://github.com/PennyLaneAI/pennylane-lightning/pull/153)

### Breaking changes

* Linux users on x86_64 must have a CPU supporting AVX.
[(#157)](https://github.com/PennyLaneAI/pennylane-lightning/pull/157)
* Linux users on `x86_64` must have a CPU supporting AVX.
[(#157)](https://github.com/PennyLaneAI/pennylane-lightning/pull/157)

### Bug fixes

* OpenMP built with Intel MacOS CI runners causes failures on M1 Macs. OpenMP is currently
disabled in the built wheels until this can be resolved with Github Actions runners.
[(#166)](https://github.com/PennyLaneAI/pennylane-lightning/pull/166)

### Contributors

This release contains contributions from (in alphabetical order):
Expand Down
145 changes: 0 additions & 145 deletions .github/workflows/deploy.yml
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions .github/workflows/wheel_linux_aarch64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
name: Wheels
name: Wheel::Linux::ARM
on:
push:
branches:
- master
release:
types: [published]

env:
CIBW_BUILD: 'cp37-* cp38-* cp39-*'
Expand Down Expand Up @@ -55,7 +57,7 @@ jobs:
CIBW_ARCHS_LINUX: ${{matrix.arch}}

- uses: actions/upload-artifact@v2
if: github.ref == 'refs/heads/master'
if: ${{ github.event_name == 'release' || github.ref == 'refs/heads/master' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the or here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I think || is supported (link https://docs.github.com/en/actions/learn-github-actions/expressions#operators) though happy to modify if you think or is better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I misunderstood. Yea, we want this to run in both cases. We can issue a release from a non master branch (the tagged v0.xy branch), and ensure the wheels are built. Master may have since move on, so we need to be able to support both ( I think).

with:
name: ${{ runner.os }}-wheels.zip
path: ./wheelhouse/*.whl
6 changes: 4 additions & 2 deletions .github/workflows/wheel_linux_ppc64le.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
name: Wheels
name: Wheel::Linux::PowerPC
on:
push:
branches:
- master
release:
types: [published]

env:
CIBW_BUILD: 'cp37-* cp38-* cp39-*'
Expand Down Expand Up @@ -52,7 +54,7 @@ jobs:
CIBW_ARCHS_LINUX: ${{matrix.arch}}

- uses: actions/upload-artifact@v2
if: github.ref == 'refs/heads/master'
if: ${{ github.event_name == 'release' || github.ref == 'refs/heads/master' }}
with:
name: ${{ runner.os }}-wheels.zip
path: ./wheelhouse/*.whl
6 changes: 4 additions & 2 deletions .github/workflows/wheel_linux_x86_64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
name: Wheels
name: Wheel::Linux::x86_64
on:
release:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the "types" line, as we do e.g. for wheel_linux_ppc64le.yml? (same question applies to some of the other workflows)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I think these need to be added to all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch -- I think these need to be added to all workflows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than changing the RC, maybe we merge this as is and modify in a subsequent PR. This won't change the wheel, and help with consistency across the wheel history. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Thanks @mlxd!

push:
branches:
- master
pull_request:


env:
CIBW_BUILD: 'cp37-* cp38-* cp39-*'

Expand Down Expand Up @@ -52,7 +54,7 @@ jobs:
CIBW_ARCHS_LINUX: ${{matrix.arch}}

- uses: actions/upload-artifact@v2
if: github.ref == 'refs/heads/master'
if: ${{ github.event_name == 'release' || github.ref == 'refs/heads/master' }}
with:
name: ${{ runner.os }}-wheels.zip
path: ./wheelhouse/*.whl
6 changes: 3 additions & 3 deletions .github/workflows/wheel_macos_arm64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
name: Wheels
name: Wheel::MacOS::ARM
on:
push:
branches:
- master
release:

env:
CIBW_BUILD: 'cp37-* cp38-* cp39-*'

# MacOS specific build settings
CIBW_BEFORE_ALL_MACOS: |
brew uninstall --force oclint
brew install libomp

# Python build settings
CIBW_BEFORE_BUILD: |
Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
CIBW_ARCHS_MACOS: ${{ matrix.arch }}

- uses: actions/upload-artifact@v2
if: github.ref == 'refs/heads/master'
if: ${{ github.event_name == 'release' || github.ref == 'refs/heads/master' }}
with:
name: ${{ runner.os }}-wheels.zip
path: ./wheelhouse/*.whl
6 changes: 4 additions & 2 deletions .github/workflows/wheel_macos_x86_64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
name: Wheels
name: Wheel::MacOS::Intel
on:
push:
branches:
- master
pull_request:
release:

env:
CIBW_BUILD: 'cp37-* cp38-* cp39-*'
Expand Down Expand Up @@ -57,9 +58,10 @@ jobs:
run: python -m cibuildwheel --output-dir wheelhouse
env:
CIBW_ARCHS_MACOS: ${{matrix.arch}}
USE_OMP: 1

- uses: actions/upload-artifact@v2
if: github.ref == 'refs/heads/master'
if: ${{ github.event_name == 'release' || github.ref == 'refs/heads/master' }}
with:
name: ${{ runner.os }}-wheels.zip
path: ./wheelhouse/*.whl
34 changes: 34 additions & 0 deletions .github/workflows/wheel_noarch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Wheel::Any::None
on:
push:
branches:
- master
pull_request:
release:

jobs:
build-pure-python-wheel:
runs-on: ubuntu-latest
steps:
- name: Checkout PennyLane-Lightning
uses: actions/checkout@v2
with:
path: main

- uses: actions/setup-python@v2
with:
python-version: '3.7'

- name: Build wheels
run: |
python -m pip install --upgrade pip wheel
cd main
python setup.py bdist_wheel
env:
SKIP_COMPILATION: True

- uses: actions/upload-artifact@v2
if: ${{ github.event_name == 'release' || github.ref == 'refs/heads/master' }}
with:
name: pure-python-wheels
path: main/dist/*.whl
5 changes: 3 additions & 2 deletions .github/workflows/wheel_win_x86_64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
name: Wheels
name: Wheel::Windows::x86_64
on:
push:
branches:
- master
pull_request:
release:

env:
CIBW_BUILD: 'cp37-* cp38-* cp39-*'
Expand Down Expand Up @@ -44,7 +45,7 @@ jobs:
uses: pypa/cibuildwheel@v1.12.0

- uses: actions/upload-artifact@v2
if: github.ref == 'refs/heads/master'
if: ${{ github.event_name == 'release' || github.ref == 'refs/heads/master' }}
with:
name: ${{ runner.os }}-wheels.zip
path: ./wheelhouse/*.whl
2 changes: 1 addition & 1 deletion pennylane_lightning/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@
Version number (major.minor.patch[-label])
"""

__version__ = "0.19.0-dev"
__version__ = "0.19.0"
Loading