Fix OpenMP library issues on M1 Macs #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.19.0-rc0 #166 +/- ##
===============================================
Coverage ? 100.00%
===============================================
Files ? 4
Lines ? 182
Branches ? 0
===============================================
Hits ? 182
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
mlxd
commented
Nov 8, 2021
| darwin_opts = ["-stdlib=libc++"] | ||
|
|
||
| # Used to enable OpenMP only on Intel | ||
| # Macs due to CI available of M1 |
There was a problem hiding this comment.
Suggested change
| # Macs due to CI available of M1 | |
| # Macs due to lacking CI availability of M1 hardware. |
mlxd
added a commit
that referenced
this pull request
Nov 15, 2021
* Version Bump `0.19.0` (#163) * Added auto version bump functionality to pl lightning (#159) * Added auto version bump functionality to pl lightning * Update .github/workflows/pre_release_version_bump.yml removed trailing white space * Update .github/workflows/post_release_version_bump.yml Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca> * Update .github/workflows/pre_release_version_bump.yml Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca> * removed flag for pennylane release as it is not required Co-authored-by: antalszava <antalszava@gmail.com> * Update pre_release_version_bump.yml (#160) * Update pre_release_version_bump.yml * Update pre_release_version_bump.yml * Update pre_release_version_bump.yml * Update .github/workflows/pre_release_version_bump.yml * Apply suggestions from code review * Update post_release_version_bump.yml swap main --> master * Update CHANGELOG.md To be consistent with other plugins and not cause errors for the auto version bumping * pre release version bump * updates * Update pennylane_lightning/_version.py * formatting updates to changelog Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca> Co-authored-by: antalszava <antalszava@gmail.com> Co-authored-by: antalszava <antalszava@users.noreply.github.com> * Fix OpenMP library issues on M1 Macs (#166) * Fix OMP issue on M1 macs * Update changelog * Fix CI builder release issues (#168) * Fix OMP issue on M1 macs * Update changelog * Fix CI builder * Trigger CI on release creation * CI wheelbuilder updates (#169) * Fix OMP with ARM MacOS * Ensure wheels uploaded to GH * Separate out noarch wheels * Update .github/CHANGELOG.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca> Co-authored-by: antalszava <antalszava@gmail.com> Co-authored-by: antalszava <antalszava@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: This PR disables OpenMP for lightning on M1 Macs due the lack of M1 support on Github Actions.
Description of the Change: OpenMP is disabled for wheels built targeting M1 Macs.
Benefits: No issues with missing symbols.
Possible Drawbacks: OpenMP support would add performance benefits when fully utilised.
Related GitHub Issues: #151