-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace niworkflows calls with dependency calls (second attempt) #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
added
the
refactor
Changes to the codebase that don't impact workflow inputs or outputs.
label
May 31, 2023
This reverts commit a4c2a07.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
===========================================
+ Coverage 50.67% 66.05% +15.37%
===========================================
Files 139 74 -65
Lines 12657 6071 -6586
===========================================
- Hits 6414 4010 -2404
+ Misses 6243 2061 -4182
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes None, but works toward #199.
Changes proposed in this pull request
aslprep.interfaces.niworkflows
module.aslprep.niworkflows.interfaces.registration.EstimateReferenceImage
to this module.aslprep.niworkflows.interfaces.registration._get_vols_to_discard()
toaslprep.utils.misc
.aslprep.utils.spaces
module. This contains the bundled niworkflows version'sspaces
module.aslprep.workflows.asl.util
module.init_validate_asl_wf
andinit_asl_reference_wf
are already present.init_enhance_and_skullstrip_asl_wf
:init_enhance_and_skullstrip_bold_wf
is only used for the PEPOLAR workflow, which shouldn't apply to ASL data. I think this means that we can switch to the newer version of sdcflows and not need the modified version ofinit_enhance_and_skullstrip_bold_wf
we currently have.Documentation that should be reviewed