Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove external dependencies #199

Closed
tsalo opened this issue Jan 30, 2023 · 1 comment · Fixed by #338
Closed

Remove external dependencies #199

tsalo opened this issue Jan 30, 2023 · 1 comment · Fixed by #338
Assignees
@tsalo
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. refactor Changes to the codebase that don't impact workflow inputs or outputs.

Comments

@tsalo
Copy link
Member

tsalo commented Jan 30, 2023

Rather than bundling the external dependencies in the repo, I'd like to install them.
@tsalo tsalo added refactor Changes to the codebase that don't impact workflow inputs or outputs. maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. labels Jan 30, 2023
@tsalo tsalo mentioned this issue Jan 30, 2023
Closed
@tsalo
Copy link
Member Author

tsalo commented Feb 11, 2023 •
edited
Loading

I'll try to document the modifications and additions here.

niworkflows

  • New functions:
    • In niworkflows.func.util, these three workflows seem to be renamed versions of the original BOLD workflows. Not sure if there were any modifications beyond the names and descriptions.
      • init_skullstrip_asl_wf
      • init_enhance_and_skullstrip_asl_wf
      • init_asl_reference_wf
  • Modified classes:
    • niworkflows.utils.spaces.Reference and niworkflows.utils.spaces.OutputReferencesAction: "asl" was added to the non-standard references list.

pybids

  • Really the only change here was the config files.

sdcflows

smriprep

This was referenced Feb 20, 2023
Merged
Closed
Merged
Closed
@tsalo tsalo self-assigned this Apr 17, 2023
@tsalo tsalo mentioned this issue May 31, 2023
Merged
@tsalo tsalo mentioned this issue Sep 28, 2023
Open
@tsalo tsalo mentioned this issue Nov 20, 2023
Merged
@tsalo tsalo closed this as completed in #338 Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsalo tsalo

Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Milestone
No milestone
1 participant
@tsalo