-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace internal pybids calls with installed pybids calls #213
Conversation
Codecov ReportBase: 39.95% // Head: 44.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 39.95% 44.18% +4.22%
==========================================
Files 192 145 -47
Lines 19940 13440 -6500
==========================================
- Hits 7967 5938 -2029
+ Misses 11973 7502 -4471
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aslprep/niworkflows/viz/utils.py
Outdated
@@ -403,8 +403,8 @@ def _compose_view(bg_svgs, fg_svgs, ref=0): | |||
else: | |||
newroots = roots | |||
fig.append(newroots) | |||
fig.root.attrib.pop("width") | |||
fig.root.attrib.pop("height") | |||
fig.root.attrib.pop("width", None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does pop not automatically return None?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It started breaking when I unpinned the svgutils version. I haven't checked what the attrib
attribute is, so it might not be a regular dictionary. I copied the fix from the current version of niworkflows.
Closes None, but works toward #199.
Changes proposed in this pull request
aslprep.pybids
withbids
(the installed dependency).