Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare ASLPrep and niworkflows skullstrip workflows #353

Closed
tsalo opened this issue Dec 5, 2023 · 1 comment · Fixed by #371
Closed

Compare ASLPrep and niworkflows skullstrip workflows #353

tsalo opened this issue Dec 5, 2023 · 1 comment · Fixed by #371
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc.

Comments

@tsalo
Copy link
Member

tsalo commented Dec 5, 2023

Summary

Need to document differences between aslprep.workflows.asl.util.init_enhance_and_skullstrip_asl_wf and niworkflows.func.util.init_enhance_and_skullstrip_bold_wf.

@tsalo tsalo added enhancement New feature or request maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. and removed enhancement New feature or request labels Dec 5, 2023
@tsalo
Copy link
Member Author

tsalo commented Dec 9, 2023

Here are notes from #299:

  • There was an image dilation step applied to the input image, then a header-check to make sure the dilation step didn't mess up the header.
  • There was a pre_mask bool parameter for when the mask was vs. was not already calculated. The "mask was not pre-generated" logic has been removed, even though the parameter remains.
  • However, in the current version of sdcflows, init_enhance_and_skullstrip_bold_wf is only used for the PEPOLAR workflow, which shouldn't apply to ASL data. I think this means that we can switch to the newer version of sdcflows and not need the modified version of init_enhance_and_skullstrip_bold_wf we currently have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant