Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITL startup fixes #9661

Merged
merged 2 commits into from
Jun 13, 2018
Merged

SITL startup fixes #9661

merged 2 commits into from
Jun 13, 2018

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented Jun 13, 2018

    WARN  [mavlink] stream SCALED_IMU2 not found
    WARN  [mavlink] stream SCALED_IMU3 not found
  • initialize adc only if BOARD_NUMBER_BRICKS > 0. Fixes the SITL startup error:
    ERROR [sensors] no ADC found: /dev/adc0 (9)

@RomanBapst can you test this quickly on Snapdragon, the eagle board config also defines BOARD_NUMBER_BRICKS to 0?

TSC21
TSC21 previously approved these changes Jun 13, 2018
bkueng added 2 commits June 13, 2018 14:27
Removes SITL startup warnings:
WARN  [mavlink] stream SCALED_IMU2 not found
WARN  [mavlink] stream SCALED_IMU3 not found

Introduced in 9122725
Fixes the SITL startup error:
ERROR [sensors] no ADC found: /dev/adc0 (9)

Introduced in 8404889
@LorenzMeier LorenzMeier merged commit 226d7c7 into master Jun 13, 2018
@LorenzMeier LorenzMeier deleted the sitl_startup_fixes branch June 13, 2018 13:54
@dagar
Copy link
Member

dagar commented Jun 13, 2018

FYI - BOARD_NUMBER_BRICKS defaults to 1 if not set in the board_config.h
https://github.com/PX4/Firmware/blob/master/src/drivers/boards/common/board_common.h#L164-L171

The ADC is also potentially used for differential pressure from the sensors module, although I'm not sure that anyone cares at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants