Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed low threshold in px4io firmware to 10%... #919

Merged
merged 1 commit into from
Jul 3, 2014
Merged

Changed low threshold in px4io firmware to 10%... #919

merged 1 commit into from
Jul 3, 2014

Conversation

TickTock-
Copy link
Contributor

...to ensure compatibility with user configured, single channel, mode switches. Compiles - not yet tested.

@TickTock-
Changed low threshold in px4io firmware to 10% to ensure compatibilit…
559c62b 
…y with user configured single channel, mode switches
@LorenzMeier
Copy link
Member

Thanks! Let us know when its tested. I will test here with the old-school setup. I'm slightly worried about the higher sensitivity for calibration, but I guess it will be fine.

@TickTock-
Copy link
Contributor Author

I have tested with multicopter and can confirm it doesn't interfere with operation of any of the modes. Ran into some difficulties trying to test the override in fixed wing mode. Really need someone with a fixed wing aircraft to test there since I don't have a baseline to compare against.

@LorenzMeier LorenzMeier added this to the First beta release milestone May 15, 2014
@DrTon DrTon modified the milestone: First beta release May 16, 2014
@LorenzMeier
Copy link
Member

@TickTock- Do you have a chance to test this? Would be highly appreciated!

@TickTock-
Copy link
Contributor Author

I do not have any fixed wing aircraft to test with so have only confirmed no adverse impact to multi-copter. It should be tested on a FW platform. I will change my setup to FW and see if it does what I think it should do (directly map control signals to four of my Multicopter ESCs), but I don't think that will be a sufficient test. Any fixed wing testers willing to give this a try?

@TickTock-
Copy link
Contributor Author

No luck yet testing as FW. When I configure as the top left FW configuration in QGC (Easystar, I believe), I don't get any output on any of the eight px4io outputs even though QGC thinks I am armed and in the air. Tried with and without this branch so I don't think it is related, just my ignorance on how to setup a FW.

@LorenzMeier
Copy link
Member

The Easystar mixer had a bug that was just fixed yesterday, sorry 8). Try one of the flying wings, those are the ones we fly regularly.

@TickTock-
Copy link
Contributor Author

Thanks. That did it. I think it tested positive. Here's what I did: Using the stable version, I characterized how the motors behaved in ALTCTL and MANUAL. Learned that in MANUAL if I put the roll all the way to the right, motor1 would stop whereas in ALTCTL it continues spinning. After loading this branch, I reconfirmed the above behavior then I changed the ASSIST_TH to 0. This prevents the FMU from ever going to MANUAL (confirmed via QGC continuing to indicate ALTCTL even when the mode switch was in the manual position). However having the mode switch in the MANUAL position did result in the previously characterize MANUAL behavior (motor1 off with hard right roll). This, I think, means that the PX4io was successfully overriding and directly applying the RC inputs to the servo outputs.

LorenzMeier added a commit that referenced this pull request Jul 3, 2014
@LorenzMeier
Merge pull request #919 from TickTock-/hotfix_override_threshold
93dcd90 
Changed low threshold in px4io firmware to 10%...
@LorenzMeier LorenzMeier merged commit 93dcd90 into PX4:master Jul 3, 2014
PX4BuildBot added a commit that referenced this pull request Jun 27, 2019
@PX4BuildBot
PX4/NuttX branch test: master
1fb745a 
NuttX:
 - https://github.com/PX4-NuttX/nuttx/tree/master
 - PX4/NuttX@f986bf1

Changes from PX4/NuttX (PX4/NuttX@423371c) in current PX4/master (49966f4)
PX4/NuttX@423371c...f986bf1

f986bf1 (HEAD, origin/master) Merged in masayuki2009/nuttx.nuttx/wireless_gs2200m (pull request #919)
40179da Squashed commit of the following:
2f9a76b arch/arm/src/samd2l2/hardware/samd_tc.h:  Correct register bit field definitions used with TC_CTRLBCLR and TC_CTRLSET registers.
a73cd66 configs/makerlisp:  This commit brings in a new configuration to support execution entirely out of external SRAM.
65ce2b6 Merged in alinjerpelea/nuttx (pull request #918)
7427cee Merged in alinjerpelea/nuttx (pull request #916)
0dff6cb Merged in masayuki2009/nuttx.nuttx/fix_audio_underrun (pull request #917)
5ad003c configs/makerlisp/src/sd_main.c: Correct some backward conditional compilation.
d7c4cca Trivial typo fix to a comment.
bfda93d Merged in alinjerpelea/nuttx (pull request #915)

Apps:
 - https://github.com/PX4/NuttX-apps/tree/master
 - PX4/NuttX-apps@d2f3ad9

Changes from PX4/NuttX-apps (PX4/NuttX-apps@7db2a35) in current PX4/master (49966f4)
PX4/NuttX-apps@7db2a35...d2f3ad9

d2f3ad9 (HEAD -> master, origin/master) Merged in masayuki2009/nuttx.apps/wireless_gs2200m (pull request #177)
2c8e349 Merged in masayuki2009/nuttx.apps/add_system_gs2200m (pull request #176)
6561573 industry/abnt_codi, include/industry/abnt_code.h, examples.abntcodi:  Adds support for ABNT CODI library.  This is an energy meter protocol used in Brazil.
bd14bf7 apps/netutils/json:  Removed.  Replaced with apps/netutils/cjson.
24e590b apps/nshlib/nsh_ddcmd.c:  Seemingly nonsense change but somehow works around a compilation error using the ZDS-II toolchain.  It was claiming that vtbl was undefined indd_outfopen().
87c1083 apps/netutils/netinit:  MAC address configuration was represented by type long long.  That is a problem for architectures that do not support typle long long.  Replaces by two long configuration items.
8c36ec3 nshlib/nsh_parse.c:  Fix a warning about an uninitialized variable from the ZDS-II compiler.
6c815a8 apps/nshlib/nsh_ddcmd.c:  Cosmetic edition of FAR
63de16b netutils/telnetd/telnetd_daemon.c:  Fix another C89 violation that caused the ez80 build to fail.
31147b9 apps/graphics/slcd:  Improve the representation of '1', 'l', and 'I'.
PX4BuildBot added a commit that referenced this pull request Jun 27, 2019
@PX4BuildBot
PX4/NuttX branch test: master
42e7a83 
NuttX:
 - https://github.com/PX4-NuttX/nuttx/tree/master
 - PX4/NuttX@b922c27

Changes from PX4/NuttX (PX4/NuttX@423371c) in current PX4/master (748ff7f)
PX4/NuttX@423371c...b922c27

b922c27 (HEAD, origin/master) Merged in alinjerpelea/nuttx (pull request #920)
f986bf1 Merged in masayuki2009/nuttx.nuttx/wireless_gs2200m (pull request #919)
40179da Squashed commit of the following:
2f9a76b arch/arm/src/samd2l2/hardware/samd_tc.h:  Correct register bit field definitions used with TC_CTRLBCLR and TC_CTRLSET registers.
a73cd66 configs/makerlisp:  This commit brings in a new configuration to support execution entirely out of external SRAM.
65ce2b6 Merged in alinjerpelea/nuttx (pull request #918)
7427cee Merged in alinjerpelea/nuttx (pull request #916)
0dff6cb Merged in masayuki2009/nuttx.nuttx/fix_audio_underrun (pull request #917)
5ad003c configs/makerlisp/src/sd_main.c: Correct some backward conditional compilation.
d7c4cca Trivial typo fix to a comment.

Apps:
 - https://github.com/PX4/NuttX-apps/tree/master
 - PX4/NuttX-apps@d2f3ad9

Changes from PX4/NuttX-apps (PX4/NuttX-apps@7db2a35) in current PX4/master (748ff7f)
PX4/NuttX-apps@7db2a35...d2f3ad9

d2f3ad9 (HEAD -> master, origin/master) Merged in masayuki2009/nuttx.apps/wireless_gs2200m (pull request #177)
2c8e349 Merged in masayuki2009/nuttx.apps/add_system_gs2200m (pull request #176)
6561573 industry/abnt_codi, include/industry/abnt_code.h, examples.abntcodi:  Adds support for ABNT CODI library.  This is an energy meter protocol used in Brazil.
bd14bf7 apps/netutils/json:  Removed.  Replaced with apps/netutils/cjson.
24e590b apps/nshlib/nsh_ddcmd.c:  Seemingly nonsense change but somehow works around a compilation error using the ZDS-II toolchain.  It was claiming that vtbl was undefined indd_outfopen().
87c1083 apps/netutils/netinit:  MAC address configuration was represented by type long long.  That is a problem for architectures that do not support typle long long.  Replaces by two long configuration items.
8c36ec3 nshlib/nsh_parse.c:  Fix a warning about an uninitialized variable from the ZDS-II compiler.
6c815a8 apps/nshlib/nsh_ddcmd.c:  Cosmetic edition of FAR
63de16b netutils/telnetd/telnetd_daemon.c:  Fix another C89 violation that caused the ez80 build to fail.
31147b9 apps/graphics/slcd:  Improve the representation of '1', 'l', and 'I'.
PX4BuildBot added a commit that referenced this pull request Jun 27, 2019
@PX4BuildBot
PX4/NuttX branch test: master
60d699b 
NuttX:
 - https://github.com/PX4-NuttX/nuttx/tree/master
 - PX4/NuttX@6256af2

Changes from PX4/NuttX (PX4/NuttX@423371c) in current PX4/master (748ff7f)
PX4/NuttX@423371c...6256af2

6256af2 (HEAD, origin/master) configs/makerlisp/scripts:  Add a linker script to support copying the NuttX image from FLASH into external SRAM.
056eebd arch/arm/src/stm32h7: Ported the QEncoder from F7 to H7.
b922c27 Merged in alinjerpelea/nuttx (pull request #920)
f986bf1 Merged in masayuki2009/nuttx.nuttx/wireless_gs2200m (pull request #919)
40179da Squashed commit of the following:
2f9a76b arch/arm/src/samd2l2/hardware/samd_tc.h:  Correct register bit field definitions used with TC_CTRLBCLR and TC_CTRLSET registers.
a73cd66 configs/makerlisp:  This commit brings in a new configuration to support execution entirely out of external SRAM.
65ce2b6 Merged in alinjerpelea/nuttx (pull request #918)
7427cee Merged in alinjerpelea/nuttx (pull request #916)
0dff6cb Merged in masayuki2009/nuttx.nuttx/fix_audio_underrun (pull request #917)

Apps:
 - https://github.com/PX4/NuttX-apps/tree/master
 - PX4/NuttX-apps@d2f3ad9

Changes from PX4/NuttX-apps (PX4/NuttX-apps@7db2a35) in current PX4/master (748ff7f)
PX4/NuttX-apps@7db2a35...d2f3ad9

d2f3ad9 (HEAD -> master, origin/master) Merged in masayuki2009/nuttx.apps/wireless_gs2200m (pull request #177)
2c8e349 Merged in masayuki2009/nuttx.apps/add_system_gs2200m (pull request #176)
6561573 industry/abnt_codi, include/industry/abnt_code.h, examples.abntcodi:  Adds support for ABNT CODI library.  This is an energy meter protocol used in Brazil.
bd14bf7 apps/netutils/json:  Removed.  Replaced with apps/netutils/cjson.
24e590b apps/nshlib/nsh_ddcmd.c:  Seemingly nonsense change but somehow works around a compilation error using the ZDS-II toolchain.  It was claiming that vtbl was undefined indd_outfopen().
87c1083 apps/netutils/netinit:  MAC address configuration was represented by type long long.  That is a problem for architectures that do not support typle long long.  Replaces by two long configuration items.
8c36ec3 nshlib/nsh_parse.c:  Fix a warning about an uninitialized variable from the ZDS-II compiler.
6c815a8 apps/nshlib/nsh_ddcmd.c:  Cosmetic edition of FAR
63de16b netutils/telnetd/telnetd_daemon.c:  Fix another C89 violation that caused the ez80 build to fail.
31147b9 apps/graphics/slcd:  Improve the representation of '1', 'l', and 'I'.
PX4BuildBot added a commit that referenced this pull request Jun 27, 2019
@PX4BuildBot
PX4/NuttX branch test: master
f1d1917 
NuttX:
 - https://github.com/PX4-NuttX/nuttx/tree/master
 - PX4/NuttX@4445a78

Changes from PX4/NuttX (PX4/NuttX@423371c) in current PX4/master (2c74216)
PX4/NuttX@423371c...4445a78

4445a78 (HEAD, origin/master) Update a README
23f14a3 Add Kconfig chane should have been a part of 6256af2.
6256af2 configs/makerlisp/scripts:  Add a linker script to support copying the NuttX image from FLASH into external SRAM.
056eebd arch/arm/src/stm32h7: Ported the QEncoder from F7 to H7.
b922c27 Merged in alinjerpelea/nuttx (pull request #920)
f986bf1 Merged in masayuki2009/nuttx.nuttx/wireless_gs2200m (pull request #919)
40179da Squashed commit of the following:
2f9a76b arch/arm/src/samd2l2/hardware/samd_tc.h:  Correct register bit field definitions used with TC_CTRLBCLR and TC_CTRLSET registers.
a73cd66 configs/makerlisp:  This commit brings in a new configuration to support execution entirely out of external SRAM.
65ce2b6 Merged in alinjerpelea/nuttx (pull request #918)

Apps:
 - https://github.com/PX4/NuttX-apps/tree/master
 - PX4/NuttX-apps@d2f3ad9

Changes from PX4/NuttX-apps (PX4/NuttX-apps@7db2a35) in current PX4/master (2c74216)
PX4/NuttX-apps@7db2a35...d2f3ad9

d2f3ad9 (HEAD -> master, origin/master) Merged in masayuki2009/nuttx.apps/wireless_gs2200m (pull request #177)
2c8e349 Merged in masayuki2009/nuttx.apps/add_system_gs2200m (pull request #176)
6561573 industry/abnt_codi, include/industry/abnt_code.h, examples.abntcodi:  Adds support for ABNT CODI library.  This is an energy meter protocol used in Brazil.
bd14bf7 apps/netutils/json:  Removed.  Replaced with apps/netutils/cjson.
24e590b apps/nshlib/nsh_ddcmd.c:  Seemingly nonsense change but somehow works around a compilation error using the ZDS-II toolchain.  It was claiming that vtbl was undefined indd_outfopen().
87c1083 apps/netutils/netinit:  MAC address configuration was represented by type long long.  That is a problem for architectures that do not support typle long long.  Replaces by two long configuration items.
8c36ec3 nshlib/nsh_parse.c:  Fix a warning about an uninitialized variable from the ZDS-II compiler.
6c815a8 apps/nshlib/nsh_ddcmd.c:  Cosmetic edition of FAR
63de16b netutils/telnetd/telnetd_daemon.c:  Fix another C89 violation that caused the ez80 build to fail.
31147b9 apps/graphics/slcd:  Improve the representation of '1', 'l', and 'I'.
PX4BuildBot added a commit that referenced this pull request Nov 5, 2022
@PX4BuildBot
Update submodule sitl_gazebo to latest Sat Nov 5 12:38:57 UTC 2022
12319d5 
    - sitl_gazebo in PX4/Firmware (1fc1a81): PX4/PX4-SITL_gazebo-classic@56b5508
    - sitl_gazebo current upstream: PX4/PX4-SITL_gazebo-classic@6c3f1f8
    - Changes: PX4/PX4-SITL_gazebo-classic@56b5508...6c3f1f8

    6c3f1f8 2022-11-03 alessandro - send orientation q with landing_target message (#919)
48e764b 2022-11-02 Frederic Taillandier - allowing to override the video stream ip in a simpler way than using the jinja file (#923)
PX4BuildBot added a commit that referenced this pull request Nov 7, 2022
@PX4BuildBot
Update submodule sitl_gazebo to latest Mon Nov 7 12:38:21 UTC 2022
55a83aa 
    - sitl_gazebo in PX4/Firmware (1fc1a81): PX4/PX4-SITL_gazebo-classic@56b5508
    - sitl_gazebo current upstream: PX4/PX4-SITL_gazebo-classic@6c3f1f8
    - Changes: PX4/PX4-SITL_gazebo-classic@56b5508...6c3f1f8

    6c3f1f8 2022-11-03 alessandro - send orientation q with landing_target message (#919)
48e764b 2022-11-02 Frederic Taillandier - allowing to override the video stream ip in a simpler way than using the jinja file (#923)
PX4BuildBot added a commit that referenced this pull request Nov 8, 2022
@PX4BuildBot
Update submodule sitl_gazebo to latest Tue Nov 8 00:38:52 UTC 2022
ad35ce4 
    - sitl_gazebo in PX4/Firmware (3e35f94): PX4/PX4-SITL_gazebo-classic@56b5508
    - sitl_gazebo current upstream: PX4/PX4-SITL_gazebo-classic@b38e701
    - Changes: PX4/PX4-SITL_gazebo-classic@56b5508...b38e701

    b38e701 2022-11-03 frederictaillandier - adding jinja parameters
cc8f33d 2022-11-03 frederictaillandier - allowing to override the streaming gimbal ip and port
6c3f1f8 2022-11-03 alessandro - send orientation q with landing_target message (#919)
48e764b 2022-11-02 Frederic Taillandier - allowing to override the video stream ip in a simpler way than using the jinja file (#923)
PX4BuildBot added a commit that referenced this pull request Nov 9, 2022
@PX4BuildBot
Update submodule sitl_gazebo to latest Wed Nov 9 00:39:01 UTC 2022
f1cf3b9 
    - sitl_gazebo in PX4/Firmware (0e2b1ee): PX4/PX4-SITL_gazebo-classic@56b5508
    - sitl_gazebo current upstream: PX4/PX4-SITL_gazebo-classic@b38e701
    - Changes: PX4/PX4-SITL_gazebo-classic@56b5508...b38e701

    b38e701 2022-11-03 frederictaillandier - adding jinja parameters
cc8f33d 2022-11-03 frederictaillandier - allowing to override the streaming gimbal ip and port
6c3f1f8 2022-11-03 alessandro - send orientation q with landing_target message (#919)
48e764b 2022-11-02 Frederic Taillandier - allowing to override the video stream ip in a simpler way than using the jinja file (#923)
@dagar dagar mentioned this pull request Nov 9, 2022
Merged
dagar pushed a commit that referenced this pull request Nov 9, 2022
@PX4BuildBot @dagar
Update submodule sitl_gazebo to latest Wed Nov 9 00:39:01 UTC 2022
b7d2868 
    - sitl_gazebo in PX4/Firmware (0e2b1ee): PX4/PX4-SITL_gazebo-classic@56b5508
    - sitl_gazebo current upstream: PX4/PX4-SITL_gazebo-classic@b38e701
    - Changes: PX4/PX4-SITL_gazebo-classic@56b5508...b38e701

    b38e701 2022-11-03 frederictaillandier - adding jinja parameters
cc8f33d 2022-11-03 frederictaillandier - allowing to override the streaming gimbal ip and port
6c3f1f8 2022-11-03 alessandro - send orientation q with landing_target message (#919)
48e764b 2022-11-02 Frederic Taillandier - allowing to override the video stream ip in a simpler way than using the jinja file (#923)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
First beta release
Development

Successfully merging this pull request may close these issues.
3 participants
@TickTock- @LorenzMeier @DrTon