Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to have out-of-tree uORB message definitions #9073

Merged

Conversation

ksschwabe
Copy link
Contributor

@ksschwabe ksschwabe commented Mar 13, 2018

If the EXTERNAL_MODULES_LOCATION variable has been set, and the
EXTERNAL_MODULES_LOCATION/msg/ directory exists containing a
CMakeLists.txt file with the following format:

    set(config_msg_list_external
      message1.msg
      message2.msg
      message3.msg
      ...
      PARENT_SCOPE
      )

then the messages defined in config_msg_list_external are added to the
msg_files list in Firmware/msg/CMakeLists.txt and are used to generate uORB
message headers. The generated uORB message headers are placed in the same
location as the normal uORB message headers in the build directory, namely,
<build_dir>/uORB/topics. The uORB topic sources are generated in
<build_dir>/msg/topics_sources.

This should help users who do a lot of out-of-tree development. This will keep the custom msg definitions out of the PX4/Firmware tree.

@ksschwabe ksschwabe force-pushed the feature_out_of_tree_uorb_msg_definition branch 2 times, most recently from 89dc11d to e467597 Compare March 13, 2018 23:06
@hamishwillee
Copy link
Contributor

@ksschwabe When this is integrated, do you think you could review whether we need to update the documentation correspondingly? Specifically, two documents may be impacted:

@ksschwabe
Copy link
Contributor Author

@hamishwillee: https://dev.px4.io/en/middleware/uorb.html can remain unchanged, but the https://dev.px4.io/en/advanced/out_of_tree_modules.html will have to be updated. I will generate a PR for that if/when this is integrated.

@mhkabir mhkabir requested a review from bkueng March 14, 2018 01:04
If the EXTERNAL_MODULES_LOCATION variable has been set, and the
EXTERNAL_MODULES_LOCATION/msg/ directory exists containing a
CMakeLists.txt file with the following format:
    set(config_msg_list_external
      message1.msg
      message2.msg
      message3.msg
      ...
      PARENT_SCOPE
      )
then the messages defined in config_msg_list_external are added to the
msg_files list in Firmware/msg/CMakeLists.txt and are used to generate uORB
message headers. The generate uORB message headers are generated in the same
location as the normal uORB message headers in the build directory, namely,
<build_dir>/uORB/topics. The uORB topic sources are generated in
<build_dir>/msg/topics_sources.
@ksschwabe ksschwabe force-pushed the feature_out_of_tree_uorb_msg_definition branch from e467597 to eda10d8 Compare March 14, 2018 08:41
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants