-
Notifications
You must be signed in to change notification settings - Fork 480
Adds description for using out-of-tree message definition #483
Adds description for using out-of-tree message definition #483
Conversation
Hi @ksschwabe Thanks for this!
No, it is fine.
I think that is a good idea. Other things:
|
Outside of scope for this fix - @bkueng (and @ksschwabe ) This doc could use a little more context on the when/why/limitations of external modules. So can you tell me:
Where do you think it should live in the devguide tree (currently this doc is an "Advanced Topic - but I'm trying to reduce that folder to a minimum, grouping topics by "what they are for")?
Thoughts? |
Looks good.
It's for downstream adopters: people/companies who want to either replace or add one or more (proprietary) module - for example a vehicle-specific position controller. It makes it easier to see which modules are company-internal, and which ones are upstream (of course we encourage people to bring their changes upstream, but this is a method that can be used for cases where they can't/don't want to).
I'm not sure I understand. They get included when following the instructions here.
Hmm, not sure. You can access all the usual PX4 API's, so you have pretty much all the flexibility.
I think that makes sense. It's not something that you need to go though when getting started. |
53f16bb
to
6f0cca1
Compare
6f0cca1
to
b6243ad
Compare
@hamishwillee: I have updated my PR with the description related to where the topics are generated. I also added a link in https://dev.px4.io/en/middleware/uorb.html to point to the new out-of-tree uORB section. |
@ksschwabe Thanks very much! I've merged this now. @bkueng Thanks for the review. I'll do a further minor tidy up with your additional info. |
Related to PR PX4/PX4-Autopilot#9073.
I wonder whether we should possibly rename this page from out_of_tree_modules.md to something that now represents that it now also includes the out-of-tree uORB message definitions?
@hamishwillee : Do you think it is necessary for me to explain that the new uORB headers and sources will be generated in the same location as the normal uORB messages?