Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Adds description for using out-of-tree message definition #483

Merged

Conversation

ksschwabe
Copy link
Contributor

@ksschwabe ksschwabe commented Mar 14, 2018

Related to PR PX4/PX4-Autopilot#9073.

I wonder whether we should possibly rename this page from out_of_tree_modules.md to something that now represents that it now also includes the out-of-tree uORB message definitions?

@hamishwillee : Do you think it is necessary for me to explain that the new uORB headers and sources will be generated in the same location as the normal uORB messages?

@hamishwillee
Copy link
Collaborator

Hi @ksschwabe

Thanks for this!

I wonder whether we should possibly rename this page from out_of_tree_modules.md to something that now represents that it now also includes the out-of-tree uORB message definitions?

No, it is fine.

@hamishwillee : Do you think it is necessary for me to explain that the new uORB headers and sources will be generated in the same location as the normal uORB messages?

I think that is a good idea.

Other things:

  1. I think that it is worth updating https://dev.px4.io/en/middleware/uorb.html with a note or section on "out of tree messages". This can simply contain link to the new doc. I can add later if you like.
  2. There will be some minor layout issues from this, but I will fix in a post-process.

@hamishwillee
Copy link
Collaborator

Outside of scope for this fix - @bkueng (and @ksschwabe )

This doc could use a little more context on the when/why/limitations of external modules. So can you tell me:

  • what are external modules typically used for? When would you use one?
  • Do external modules get included in firmware builds when you build PX4?
  • Are there things you can't do with them?

Where do you think it should live in the devguide tree (currently this doc is an "Advanced Topic - but I'm trying to reduce that folder to a minimum, grouping topics by "what they are for")?

Thoughts?

@bkueng
Copy link
Member

bkueng commented Mar 15, 2018

Looks good.

what are external modules typically used for? When would you use one?

It's for downstream adopters: people/companies who want to either replace or add one or more (proprietary) module - for example a vehicle-specific position controller. It makes it easier to see which modules are company-internal, and which ones are upstream (of course we encourage people to bring their changes upstream, but this is a method that can be used for cases where they can't/don't want to).

Do external modules get included in firmware builds when you build PX4?

I'm not sure I understand. They get included when following the instructions here.

Are there things you can't do with them?

Hmm, not sure. You can access all the usual PX4 API's, so you have pretty much all the flexibility.

We could leave this where it is - after all it is an advanced topic

I think that makes sense. It's not something that you need to go though when getting started.

@ksschwabe ksschwabe force-pushed the out_of_tree_uorb_message_definition branch from 53f16bb to 6f0cca1 Compare March 15, 2018 09:20
@ksschwabe ksschwabe force-pushed the out_of_tree_uorb_message_definition branch from 6f0cca1 to b6243ad Compare March 15, 2018 09:38
@ksschwabe
Copy link
Contributor Author

@hamishwillee: I have updated my PR with the description related to where the topics are generated.

I also added a link in https://dev.px4.io/en/middleware/uorb.html to point to the new out-of-tree uORB section.

@hamishwillee hamishwillee merged commit 0bc7776 into PX4:master Mar 20, 2018
@hamishwillee
Copy link
Collaborator

@ksschwabe Thanks very much! I've merged this now. @bkueng Thanks for the review. I'll do a further minor tidy up with your additional info.

@ksschwabe ksschwabe deleted the out_of_tree_uorb_message_definition branch March 20, 2018 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants