-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor airspeed sensor startup improvements #7903
Conversation
@@ -66,8 +66,6 @@ if ver hwcmp PX4FMU_V2 | |||
then | |||
# External I2C bus | |||
hmc5883 -C -T -X start | |||
|
|||
# External I2C bus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we leave this as is to avoid the rebase when FMUv1 comes out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I suppose so.
|
||
# Start either MPU9250 or BMI160. They are both connected to the same SPI bus and use the same | ||
# Start either ICM2060X or BMI055. They are both connected to the same SPI bus and use the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would think we could check one Bosch sensor first. If it is present do the only Bosch path. I do not have the HW to validate this, do you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have a couple standard pixracers. Looking at the code again, the bmi055 gyro chip select is actually shared with the hmc, although grouping it like this shouldn't matter.
Also the external i2c bmm150 isn't actually pixracer specific, but I think it was thrown in at the same time for development/testing.
At this point it's largely cosmetic for keeping the console clean during boot (and slightly faster).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dagar Other than noted for the Bosch start up the rest of this makes good sense.
Do you want to decouple that part?
f285e6a
to
d558704
Compare
Rebased and tested a couple different devices. |
d558704
to
9ad21b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dagar - I will have bosch HW in a few days- I think the easiest way to vet this is to compare the boot on V4 and V4 with bosch sensors and ensure the end result is the same as master. How does that sound?
Thanks, sounds good. |
I'll rebase on top of #8005 once it's in. |
9ad21b5
to
e43ba01
Compare
Rebased on master. |
The extra lis3mdl is optional external i2c that wasn't started before. |
e43ba01
to
fb316fd
Compare
fb316fd
to
28ef9ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff to the laste is simple and looks Ok
Still a mess, but slightly better than it was before. I tested an ms4525 and ms5525.
For the driver runner we need to do a better job handling trying to start multiple sensors. Right now the error messages are fairly generic and unhelpful. They're all external and optional.