mavlink: fix odometry frames of reference setup #14990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSC21
force-pushed
the
pr-fix_frames_of_reference
branch
from
def341d to
1ac73e9
Compare
kamilritz
reviewed
May 28, 2020
TSC21
force-pushed
the
pr-fix_frames_of_reference
branch
from
1ac73e9 to
22d0c81
Compare
TSC21
force-pushed
the
pr-fix_frames_of_reference
branch
from
22d0c81 to
bbb3a57
Compare
kamilritz
previously approved these changes
May 28, 2020
|
@kamilritz sorry just a little detail more and should be good to go. Thanks for reviewing! |
kamilritz
approved these changes
May 28, 2020
|
ROS builds are failing since we don't have an up to date release of Mavlink on ROS. I think we can ignore or comment those for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
Fixes the odometry MAVlink frames of reference and estimation source handling.
Describe your solution
Adds the usage of the and depending on the
MAV_ESTIMATOR_TYPE, splits the odometry stream where required.Brings along some other updates in the sitl_gazebo and mavlink submodules, including PX4/PX4-SITL_gazebo-classic#506.
Test data / coverage
Tested in SITL.