-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] icm20689: track consecutive failures and trigger reset #14646
Conversation
dagar
commented
Apr 11, 2020
- potential fix for test rack CUAV v5 nano icm20689 persistent transfer errors #14644
It's not clear to me this is much of a problem in general, but in an effort to make these drivers as robust as possible I'm going to implement the consecutive failure count + reset everywhere. |
353c0c3
to
ff302ea
Compare
96e9cf9
to
ff302ea
Compare
No impact on the bad board. I'll look at adding the self test. |
I'm fairly certain there's an actual problem with the icm20689 on the test rack's CUAV v5 Nano. This is actually a good case to review from the driver's perspective because we can catch the error fairly early and trigger a reset, but that might actually be the wrong thing to do. The sensor will reset, work for a brief period, then start producing errors, repeat. The end result is enough valid data the sensors module doesn't actual flag a timeout. |
ff302ea
to
79b616c
Compare
Fixed in master. |