Retune SITL model typhoon h480 #13246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSC21
added
Sim: gazebo classic
TSC21
approved these changes
Oct 23, 2019
|
It is MC_PITCH_P and MC_ROLL_P, not MC_PITCH and MC_ROLL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
This Fixes #13163 where the typhoon_480 was showing oscillations is forward flight in SITL
Describe your solution
These are the retuned values of the typhoon h480 coming from the suggestion of @dayjaby
Test data / coverage
Log: https://review.px4.io/plot_app?log=7d5eae16-1c0e-4c42-8912-b9176f4d27e6