commander calibration routines initialize everything #13052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
force-pushed
the
pr-calibration_cleanup_minor
branch
2 times, most recently
from
1c0f703 to
d70325e
Compare
dagar
force-pushed
the
pr-calibration_cleanup_minor
branch
from
d70325e to
c3c1e21
Compare
|
TODO: recalibrate everything on v5 with stackcheck |
julianoes
previously approved these changes
Oct 1, 2019
| @@ -368,9 +368,9 @@ int do_accel_calibration(orb_advert_t *mavlink_log_pub) | |||
|
|
|||
| /* update the _SCL_ terms to include the scale factor */ | |||
| for (unsigned axis_index = 0; axis_index < 3; axis_index++) { | |||
| val = 1.0f; | |||
| float val = 1.0f; | |||
| (void)sprintf(str, "TC_A%u_SCL_%u", sensor_correction.accel_mapping[uorb_index], axis_index); | |||
Co-Authored-By: Julian Oes <julian@oes.ch>
julianoes
previously approved these changes
Oct 1, 2019
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
dagar
force-pushed
the
pr-calibration_cleanup_minor
branch
from
b04e60b to
91eb7ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this is just being paranoid and even borderline unnecessary, but there were a couple cases of possibly uninitialized variables being used (tc_locked for example).