VTOL: fix land detector during transitions to fix MC throttle drops #12903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t beginnung due to landing detected Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
sfuhrer
changed the title
sfuhrer
changed the title
|
Should VtolLandDetector return false for "maybe_landed" and "get_landed_state" if it's in transition? During transitions "is_rotary_wing" will return true. Currently it only checks if it is in fixed wing - which I believe will return false during transitions. |
|
You can do this in the |
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
|
I would still vote for preventing any landing detection during transitions, anybody opposed to that? |
|
@sfuhrer I agree. |
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12877
Problem was that during the backtransitions, the MC land detector detected landing and because of that set the throttle to 0.
With this PR, the min throttle check is disabled for transitions.
Only bench tested yet.
Currently only the MC land detector is running for VTOL. During FW flight it always returns false. #12779
For transitions the fixed-wing land detector could be used (with relaxed airspeed check), a dedicated VTOL land detector implemented or the land detector simply deactivated (as it's here more or less done).