FTP List, Open, Read, Terminate commands working end to end with QGC #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed various bugs. Flattened Mavlink::Session class while fixing bugs in this area.
LorenzMeier
added a commit
that referenced
this pull request
Jun 28, 2014
FTP List, Open, Read, Terminate commands working end to end with QGC
PX4BuildBot
added a commit
that referenced
this pull request
Dec 2, 2019
NuttX: - https://github.com/PX4-NuttX/nuttx/tree/master - PX4/NuttX@15f358d Changes from PX4/NuttX (PX4/NuttX@398a59a) in current PX4/master (9b66cbd) PX4/NuttX@398a59a...15f358d 15f358d (HEAD, origin/master) arch/arm/src/stm32f0l0g0: Fix PWM on TIM16 not working: Adjust TIM registers, Add pins available for mapping TIM14-17, CCMR2 registers was being handled for TIMs who do not have it, and Fix PWM frequency being doubled when in center-aligned mode. f46e5d5 Merged in masayuki2009/nuttx.nuttx/fe310_updates (pull request #1085) b599aa0 fs/cromfs/fs_cromfs.c: Back out an erroneous change I made during a code review. Noted by Jussi Kivilinna. 4e2b2e8 Coding standard corrections in last PR. db49e62 Merged in kyChuGit/nuttx/aht10_sensor (pull request #1084) 7dfae77 .gignore: Remove /pcode. P-code support is gone. 1e2c840 Merged in OSer916/nuttx/fix_stm32l4_sai (pull request #1083) 2007709 Merged in masayuki2009/nuttx.nuttx/spresense_with_elf (pull request #1082) cc0a0e7 arch/arm/src/armv7-m/up_schedulesigaction.c: Correct hardfault that can occur when killing a task via Ctrl-C in PROTECTED mode. 736a0da Fix various coding standard problems in last PR, mostly as reported by tools/nxstyle. Apps: - https://github.com/PX4/NuttX-apps/tree/master - PX4/NuttX-apps@0343ea1 Changes from PX4/NuttX-apps (PX4/NuttX-apps@91b6ad6) in current PX4/master (9b66cbd) PX4/NuttX-apps@91b6ad6...0343ea1 0343ea1a (HEAD -> master, origin/master) examples/udpblaster/Makefile: change UDPBLASTER_PROGNAME to CONFIG_UDPBLASTER_PROGNAME to fix the compile error: apps\include" -Dmain udpblaster_target.c -o udpblaster_target.o <command-line>:0:6: error: expected identifier or '(' before numeric constant udpblaster_target.c:196:5: note: in expansion of macro 'main' 9f1aa3c3 (origin/px4_firmware_nuttx-8.2+) apps//examples/netlink_route: Correct format when printing ARP table entries. eff16338 Remove apps/grephics/traveler 96670609 Remove apps/system/sudoku. 23d2785b system/spi/Kconfig: Simultaneous with Dave Marples patch, kyChu submitted a nearly equivalent change with PR 206. In have enhanced Dave Marples change with some good things form kyChu's PR. 12224806 system/spi/Kconfig: This patch fixes a missing definition in the spitool when SPI is enabled with command/data switching. e89a1aa5 README.txt: Update to include a description of the 'dmesg' command which was apparently never documented. 3ebf7109 Remove all support for the ancient Pascal compiler and pcode interpreter. c084cd82 apps/system/nxplayer and nxrecorder: apps/nxplayer&nxrecorder: Add nuttx shell support. Use system() function to support shell command in nxplayer and nxrecorder applications. 1859f563 apps/netutils/netinit, apps/netutils/netlib/, and apps/include/netutils/netlib.h: Extend a few definitions to permit building netutils and netinit with only Netlink sockets enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In combination with this pull: mavlink/qgroundcontrol#733, all of this now works end to end.
Fixed various bugs. Ran into a bunch of problems with Session handling. I flattened Mavlink::Session class while fixing bugs in this area to make it easier to understand.
Note the significant change in _mavlink_main.cpp where it uses mavlink_resend_uart to send the messages out on the wire from the ring buffer. Previous code was causing bad data to be sent on the wire. Also hardcore review of the mutex changes (also in mavlink_ftp.h) would be helpful.