Mavlink FTP: List and Download commands working end to end #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also modified protocol to better support eof’s on list and read commands.
|
FYI: This is failing QGCUASFileManager unit test on Windows only (of course). I'll take a look at it tomorrow. After this is fixed and the above code reviewed. This code should be ready to go into master and no longer be WIP. |
|
Fixed strange Windows only std::string problem. This is good to go now. |
|
Awesome progress! I think our users are desperate for convenient log file download |
LorenzMeier
added a commit
that referenced
this pull request
Jun 28, 2014
Mavlink FTP: List and Download commands working end to end
|
I’ll update to UI to make it better in general as well as specific quick access to logs. On Jun 28, 2014, at 12:35 PM, Lorenz Meier notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI: I switched back to using a Nak:kErrEOF to signal end of read loops for List and Read commands. Other options overcomplicated things both on the QGC and PX4Firmware side.
This has List, Open, Read and Terminate fully working. Requires a PX4Firmware pull which I also have to get it all to work. Still have a list of work items against this, but it is mostly additional hardening and more comprehensive unit testing at this point.
Next steps: