Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data files to reflect July 2020 changes in CBO economic projections and create new ppp.py #2462

Merged
merged 6 commits into from
Aug 20, 2020

Conversation

Peter-Metz
Copy link
Contributor

@Peter-Metz Peter-Metz commented Aug 20, 2020

Two components to this PR:

  • Incorporates data files produced by Adjustment to January 2020 CBO economic projections due to COVID-19 taxdata#332 which prompts updates to inflation-indexed parameters for future years and extrapolated attributes of the filing units in the puf and cps files.
  • Creates a new ppp.py file. Tax-Calculator's adoption of Paramtools for parameter processing necessitated a new ppp.py script due to changes in the way parameters are defined. The functionality is similar. Moving forward, ppp.py will need to be run whenever inflation rates are updated in growfactors.csv. Thanks to @hdoupe for helping sort out some Paramtools issues.

Edit: the changes to ppp.py are now handled in #2466

cc @MattHJensen

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #2462 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2462   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          13       13           
  Lines        2582     2582           
=======================================
  Hits         2580     2580           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7fa89...a5d728c. Read the comment docs.

@hdoupe
Copy link
Collaborator

hdoupe commented Aug 20, 2020

Looks good @Peter-Metz. I'll get the updates into ParamTools tomorrow.

@MattHJensen
Copy link
Contributor

@Peter-Metz, thanks a lot for this PR and working through the ppp.py update for ParamTools (Thanks for your help @hdoupe!).

My sense -- but I may be misunderstanding -- is that separating out the ppp.py changes from the data update into two different PRs would allow us to better verify that the ppp.py changes are working as expected. I.e., we should see no test difference in the ppp.py PR. Does that makes sense to you?

@Peter-Metz
Copy link
Contributor Author

separating out the ppp.py changes from the data update into two different PRs would allow us to better verify that the ppp.py changes are working as expected. I.e., we should see no test

@MattHJensen I made sure of this locally (and actually uncovered a tiny error in pcl -- II_em_ps was not using the latest inflation rates for 2026), and there were no changes in values. The only other difference is that ppp.py switches the order of the values key and EIC key for EITC_c, although I don't think this matters.

I'm still happy to open a separate PR. Let me know your preference.

@MattHJensen
Copy link
Contributor

MattHJensen commented Aug 20, 2020

@MattHJensen I made sure of this locally (and actually uncovered a tiny error in pcl -- II_em_ps was not using the latest inflation rates for 2026), and there were no changes in values. The only other difference is that ppp.py switches the order of the values key and EIC key for EITC_c, although I don't think this matters.

I'm still happy to open a separate PR. Let me know your preference.

Thanks @Peter-Metz, since you are willing to separate the PRs, let's do that for posterity.

@Peter-Metz
Copy link
Contributor Author

@MattHJensen sure thing, see #2466

@MattHJensen
Copy link
Contributor

@Peter-Metz, this is looking good, but the PR now has merge conflicts. Could you drop the (new) WIP tag when they are resolved?

Also, could you help me understand why there are changes to the cpscsv output in this PR?

@MattHJensen MattHJensen changed the title Update data files to reflect July 2020 changes in CBO economic projections and create new ppp.py [WIP] Update data files to reflect July 2020 changes in CBO economic projections and create new ppp.py Aug 20, 2020
@Peter-Metz
Copy link
Contributor Author

Also, could you help me understand why there are changes to the cpscsv output in this PR?

This is due to changes in growfactors.csv. I intentionally did not include growfactors.csv in #2444 to try to separate changes in results from the new CPS file and from the CBO update.

@Peter-Metz Peter-Metz changed the title [WIP] Update data files to reflect July 2020 changes in CBO economic projections and create new ppp.py Update data files to reflect July 2020 changes in CBO economic projections and create new ppp.py Aug 20, 2020
@Peter-Metz
Copy link
Contributor Author

@MattHJensen conflicts should be resolved

@MattHJensen
Copy link
Contributor

This is due to changes in growfactors.csv. I intentionally did not include growfactors.csv in #2444 to try to separate changes in results from the new CPS file and from the CBO update.

Ok, that's great.

I am merging. Thanks again for this PR @Peter-Metz and thanks for the data update in TaxData @chusloj and review of the TaxData update @andersonfrailey!

@MattHJensen MattHJensen merged commit fe06517 into PSLmodels:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants