Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ppp.py #2466

Merged
merged 4 commits into from
Aug 20, 2020
Merged

New ppp.py #2466

merged 4 commits into from
Aug 20, 2020

Conversation

Peter-Metz
Copy link
Contributor

This PR creates a new ppp.py file. Tax-Calculator's adoption of Paramtools for parameter processing necessitated a new ppp.py script due to changes in the way parameters are defined. The functionality is similar. Moving forward, ppp.py will need to be run whenever inflation rates are updated in growfactors.csv. Thanks to @hdoupe for helping sort out some Paramtools issues.

Changes to policy_current_law.json and aggregate testing files are due to a small change in the 2026 parameter values for II_em_ps. Previously, II_em_ps was not using the most recent inflation rates for future parameter values. Also, there is some minor shuffling of json keys for the ID switch parameters (cc @hdoupe).

@MattHJensen

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #2466 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2466   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          13       13           
  Lines        2582     2582           
=======================================
  Hits         2580     2580           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cb7504...979d2cf. Read the comment docs.

@MattHJensen
Copy link
Contributor

Thanks @Peter-Metz. This looks good. Merging.

Changes to policy_current_law.json and aggregate testing files are due to a small change in the 2026 parameter values for II_em_ps. Previously, II_em_ps was not using the most recent inflation rates for future parameter values.

This happened because I merged #2402 and #2403 within a day of each other and didn't ensure that the changes to the first made it into the second.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants