Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment to January 2020 CBO economic projections due to COVID-19 #332

Merged
merged 15 commits into from
Aug 10, 2020

Conversation

chusloj
Copy link
Contributor

@chusloj chusloj commented Jun 11, 2020

This PR updates taxdata to reflect updates to CBO Economic Projects due to COVID-19. The general steps I took were:

  1. Follow instructions in CBO_Baseline_Updating_Instructions.md
  2. Run make all

Updated data is pulled from the CBO's May 2020 projections for 2020-2021

UPDATE: New data is now pulled from the CBO's July 2020 Economic Projections for 2020-2030. All variables listed under Variables in 10-Year CBO Projections within CBO_Baseline_Updating_Instructions.md were updated and unemployment compensation (UCOMP) was updated with March 2020 data (see this comment).

@chusloj chusloj changed the title CBO covid update Update January 2020 CBO projects to include data adjusted for COVID-19 Jun 11, 2020
@chusloj chusloj changed the title Update January 2020 CBO projects to include data adjusted for COVID-19 Update to January 2020 CBO projections to include data adjusted for COVID-19 Jun 11, 2020
@chusloj chusloj changed the title Update to January 2020 CBO projections to include data adjusted for COVID-19 Update to January 2020 CBO economic projections to include CBO data adjustments due to COVID-19 Jun 11, 2020
@chusloj chusloj changed the title Update to January 2020 CBO economic projections to include CBO data adjustments due to COVID-19 Update to January 2020 CBO economic projections to adjust data due to COVID-19 Jun 11, 2020
@chusloj chusloj changed the title Update to January 2020 CBO economic projections to adjust data due to COVID-19 Adjustment to January 2020 CBO economic projections due to COVID-19 Jun 11, 2020
@MattHJensen
Copy link
Contributor

MattHJensen commented Jun 16, 2020

Thank you for opening this PR @chusloj! Looking forward to following your progress. Please feel free to remove the in progress label when this is ready for review and leave a comment expressing the same.

@chusloj
Copy link
Contributor Author

chusloj commented Jun 19, 2020

UPDATE: make all has been run

The 2019 values for all variables listed under Variables in 10-Year CBO Projections within CBO_Baseline_Updating_Instructions.md were updated to reflect actual (not projected) values.

After running the makefile, test_growfactors.py shows that the 2022 growth rate within growfactors.csv for ADIVS (Dividend Income, Personal) exceeds the growth rate limit of 1.6 set in test_growfactors.py by ~6%. Would like @MattHJensen to comment on this.

Minor updates have been made to the StatMatch README and general README file. Documentation for the cps-matched-puf.csv is currently being constructed.

@chusloj
Copy link
Contributor Author

chusloj commented Jun 22, 2020

The maximum grow factor within test_growfactors.py has been increased from 1.6 to 1.7.

@chusloj chusloj changed the title Adjustment to January 2020 CBO economic projections due to COVID-19 Adjustment to January 2020 CBO economic projections due to COVID-19 [Ready] Jun 22, 2020
@andersonfrailey
Copy link
Collaborator

Thanks for working on this, @chusloj! With the merging of #314, you'll need to recreate the CPS weights. I haven't updated documentation for this yet, but if you just run cps_stage2/stage2.py after pulling all the updates to your local branch you should be good to go.

@chusloj chusloj changed the title Adjustment to January 2020 CBO economic projections due to COVID-19 [Ready] Adjustment to January 2020 CBO economic projections due to COVID-19 Jun 25, 2020
@chusloj
Copy link
Contributor Author

chusloj commented Jun 30, 2020

UPDATE: The CBO will release new 10-year economic projections on 7/2/2020. This PR will be re-updated after this release.

@chusloj
Copy link
Contributor Author

chusloj commented Jul 6, 2020

Weights have been recalculated using the newest CBO data. The variables listed under Variables in 10-Year CBO Projections have been updated with July 2020 data and unemployment compensation (UCOMP) has been updated with March 2020 data.

updatecbo.py has been updated because of problems recognizing data from the budgetary projections .xlsx file related to multi-indexing in pandas.

@MattHJensen @andersonfrailey @Peter-Metz

@chusloj chusloj changed the title Adjustment to January 2020 CBO economic projections due to COVID-19 Adjustment to January 2020 CBO economic projections due to COVID-19 [Ready] Jul 9, 2020
puf_stage1/updatecbo.py Outdated Show resolved Hide resolved
@Peter-Metz
Copy link
Contributor

Peter-Metz commented Jul 22, 2020

@chusloj thanks a lot for the PR and sorry for the slow review. Things look good to me, but I have a couple of minor questions:

  • What was the thinking for removing the README?
  • Do the dates in the docs for CGNS data need to be updated? It looks like the CGNS numbers changed but I'm not sure.

For peace of mind, it might be nice to produce tables that use the new CPS/PUF weights to illustrate the aggregate changes in Tax-Calc statistics similar to the ones in #331 (comment)

Also, it might be helpful to add a note to the initial comment in this PR explaining that this PR now updates economic projections per the July CBO report and provide a link to that report.

@chusloj
Copy link
Contributor Author

chusloj commented Jul 22, 2020

What was the thinking for removing the README?

Not sure how that disappeared. README.md from the master branch has been restored to the repo.

Do the dates in the docs for CGNS data need to be updated?

No, the new values are the exact decimal numbers from the most recent CBO budgetary projections listed in the docs. The previous numbers were just the rounded numbers.

@chusloj chusloj changed the title Adjustment to January 2020 CBO economic projections due to COVID-19 [Ready] Adjustment to January 2020 CBO economic projections due to COVID-19 Jul 22, 2020
@chusloj
Copy link
Contributor Author

chusloj commented Jul 23, 2020

@Peter-Metz Here's the diff tables you suggested above:

Pre-PUF change:

puf_before

Post-PUF change:

puf_after

These tables are for changes in the PUF weights only because the number of records in the new CPS weights file is different from the current CPS weights file in Tax Calculator which was compiled before #314 was merged. I'll hold off on making a CPS comparison until that new CPS weight file pre-CBO update is added to Tax Calculator. @andersonfrailey

@Peter-Metz
Copy link
Contributor

Thanks for the tables @chusloj. The magnitude and direction of the changes make sense to me. Think that resolves all of my questions

cc @MattHJensen

@andersonfrailey
Copy link
Collaborator

This looks good to me, @chusloj. @Peter-Metz good with me merging this and then updating your tax-calc pr?

@Peter-Metz
Copy link
Contributor

@andersonfrailey yep, good to merge! We might want to keep Tax-Calculator#2444 and the PR for CBO updates separate to be able to separate out how results change for each data modification

@andersonfrailey
Copy link
Collaborator

@Peter-Metz I think that's a good idea. Anything you want to add/update with this, @chusloj ? I'll merge if you're all good.

@chusloj
Copy link
Contributor Author

chusloj commented Aug 10, 2020

@andersonfrailey All good, ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants