Refactor fuzzing logic #1979
Merged
Refactor fuzzing logic #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1979 +/- ##
======================================
Coverage 100% 100%
======================================
Files 38 38
Lines 3755 3756 +1
======================================
+ Hits 3755 3756 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is the last of several pull requests that streamline and speed-up the creation of PUF results in the TaxBrain Interface (tbi) to Tax-Calculator. The earlier pull requests in this series were #1972, #1973 and #1976.
The effects of this series of enhancements are as follows:
The strength of the PUF fuzzing (in terms of maintaining the privacy of PUF filing units) has been increased in two ways: (a) filing units in each bottom and top decile subgroup have been fuzzed; and (b) filing units are considered for fuzzing if their combined tax liability is changed by the reform being simulated.
The speed of results preparation has been increased substantially: (a) the execution time for CPS results preparation is now about 22 seconds (while in Tax-Calculator 0.18.0 it was roughly 100 seconds); and (b) the PUF results preparation (which includes fuzzing) is now about 14 seconds.
The memory space used in results preparation has been reduced: (a) the maximum memory usage when using the full CPS data in a
tbi.run_nth_year_tax_calc_modelcall is now about 3.9 GB (while in Tax-Calculator 0.18.0 it was roughly 5.9 GB); and (b) the maximum memory usage when using the full PUF data in atbi.run_nth_year_tax_calc_modelcall is now about 2.2 GB.