Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline logic of create_difference_table utility and improve tbi fuzzing #1973

Merged
merged 4 commits into from
Apr 17, 2018
Merged

Streamline logic of create_difference_table utility and improve tbi fuzzing #1973

merged 4 commits into from
Apr 17, 2018

Conversation

martinholmer
Copy link
Collaborator

This pull request refactors the create_difference_table utility function and then makes it use the decile_details option added to the add_quantile_table_row_variable function in #1972.

Together these changes produce the following results:

  1. The logic of the create_difference_table utility has been considerably simplified and made more accurate.
  2. The fuzzing of difference table PUF results in the TaxBrain Interface (tbi) has been strengthened by fuzzing each of the subgroups of the bottom and top deciles (rather than fuzzing just the whole bottom decile and the whole top decile).

@codecov-io
Copy link

codecov-io commented Apr 17, 2018

Codecov Report

Merging #1973 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1973   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          38      38           
  Lines        3783    3756   -27     
======================================
- Hits         3783    3756   -27
Impacted Files Coverage Δ
taxcalc/utilsprvt.py 100% <ø> (ø) ⬆️
taxcalc/utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af2a53...b92cacb. Read the comment docs.

@martinholmer martinholmer merged commit 5006cff into PSLmodels:master Apr 17, 2018
@talumbau talumbau removed the ready label Apr 17, 2018
@martinholmer martinholmer deleted the redo-diff-table branch April 19, 2018 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants