Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: portal ocp #35

Merged
merged 12 commits into from
Jan 16, 2024
Merged

feat: portal ocp #35

merged 12 commits into from
Jan 16, 2024

Conversation

mikejgray
Copy link
Collaborator

@mikejgray mikejgray commented Jan 14, 2024

Closes #24

feat: uses OCP for Portal sounds that are long, to make them interruptible
fix: grandma_mode not properly filtering out all spicy sounds
test: adds unit test coverage ~60% with stubs for the rest

__init__.py Outdated Show resolved Hide resolved
resolves ModuleNotFoundError: No module named 'setuptools'
@mikejgray
Copy link
Collaborator Author

@mikejgray mikejgray marked this pull request as ready for review January 16, 2024 04:25
@mikejgray mikejgray requested review from JarbasAl and a team January 16, 2024 04:26
__init__.py Outdated Show resolved Hide resolved
__init__.py Show resolved Hide resolved
@mikejgray
Copy link
Collaborator Author

---------- coverage: platform darwin, python 3.10.9-final-0 ----------
Name                                                                                                             Stmts   Miss  Cover
------------------------------------------------------------------------------------------------------------------------------------
/Users/Mike/Documents/coding/VoiceAssistants/.venv/lib/python3.10/site-packages/skill_easter_eggs/__init__.py      120     49    59%
/Users/Mike/Documents/coding/VoiceAssistants/.venv/lib/python3.10/site-packages/skill_easter_eggs/constants.py       1      0   100%
/Users/Mike/Documents/coding/VoiceAssistants/.venv/lib/python3.10/site-packages/skill_easter_eggs/stardate.py       80     48    40%
/Users/Mike/Documents/coding/VoiceAssistants/.venv/lib/python3.10/site-packages/skill_easter_eggs/version.py         4      4     0%
------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                              205    101    51%

====================================================================== 22 passed, 5 warnings in 1.84s =======================================================================

@mikejgray mikejgray requested a review from JarbasAl January 16, 2024 04:45
README.md Outdated Show resolved Hide resolved
@mikejgray mikejgray requested a review from JarbasAl January 16, 2024 04:48
@JarbasAl JarbasAl merged commit 06ecbff into dev Jan 16, 2024
@mikejgray mikejgray deleted the FEAT_PortalOCP branch January 16, 2024 04:52
@github-actions github-actions bot mentioned this pull request Jul 5, 2024
mikejgray added a commit that referenced this pull request Jul 18, 2024
* Increment Version

* fix: correction to version.py

* fix: release automation (#20)

* fix: release automation

* fix: setup looks for correct version

* fix: adjust version location

* Increment Version to

* Update Changelog

* chore: versioning

* Increment Version to

* Update Changelog

* version

* Increment Version to

* Update Changelog

* Increment Version to

* fix: alpha release flow

* Increment Version to 0.1.2a1

* Update Changelog

* chore: Make README.md examples fit typical style (#22)

The prior copy looked out of place in the rest of the homescreen
examples, which are all capitalized and end in punctuation.

* Update skill.json

* more stt mistranscriptions for DukeNukemKeyword.voc (#26)

* Increment Version to 0.1.2a2

* Update Changelog

* update imports (#30)

* update imports

remove invalid license header, boilerplate copy paste from ancient times

I'm the original author, in case of doubt the GPL license in header does not apply

* Update skill.json

---------

Co-authored-by: JarbasAl <JarbasAl@users.noreply.github.com>

* Increment Version to 0.1.2a3

* Update Changelog

* chore: standardize naming, move files to locale dir (#32)

* chore: standardize naming, move files to locale dir

* Increment Version to 0.1.2a4

* Update Changelog

* feat: portal ocp (#35)

* tests

* feat: glados mp3s to OCP playback

* use OCP API, stub and start writing tests

* Update skill.json

* rename unit test file

* broader coverage

* syntax

* remove 3.12 tests

resolves ModuleNotFoundError: No module named 'setuptools'

* remove errant todo

* remove unsupported use case

* remove confusing and unnecessary section from README

* Update skill.json

---------

Co-authored-by: mikejgray <mikejgray@users.noreply.github.com>

* Increment Version to 0.1.2a5

* Update Changelog

* feat: best in life (#34)

* feat: what is best in life?

* tests

* add resources

* drop explicit 3.7 support

Since this isn't a default skill anywhere, users must install it explicitly, so maintaining support for EOL Python doesn't make a ton of sense. Plus it's making the tests fail.

* Increment Version to 0.1.2a6

* Update Changelog

* feat: malibu stacey and bill and ted easter eggs (#37)

* feat: malibu stacey and bill and ted easter eggs
Addresses #28

* bump minerva version to ovos-workshop compat

* remove copyrighted sounds

* Increment Version to 0.1.2a7

* Update Changelog

* automations/translations

* translations/allow_UNUSED_keywords

* Increment Version to 0.1.2a8

* Update Changelog

* Re-enable intent tests (#39)

* Update skill.json

* feat: singing (#40)

* feat: singing skill port
Closes #2
* feat: container support

If the environment variable is set indicating OVOS is running in a container, pass the GitHub URL of the file to OCP instead of the local URL. Naturally only works if the assistant has an internet connection to GitHub.

Co-authored-by: mikejgray <mikejgray@users.noreply.github.com>

* Increment Version to 0.1.2a9

* Update Changelog

* feat: make it snow (#33)

* feat: snow on Christmas

* Increment Version to 0.1.2a10

* Update Changelog

* fix: laws of robotics (#43)

* fix: laws of robotics

Only one law at a time when requesting a specific law

* Increment Version to 0.1.2a11

* Update Changelog

* Increment Version to 1.0.0

---------

Co-authored-by: mikejgray <mikejgray@users.noreply.github.com>
Co-authored-by: Mike Gray <mike@graywind.org>
Co-authored-by: AJ Jordan <alex@strugee.net>
Co-authored-by: JarbasAI <33701864+JarbasAl@users.noreply.github.com>
Co-authored-by: JarbasAl <JarbasAl@users.noreply.github.com>
Co-authored-by: miro <jarbasai@mailfence.com>
Co-authored-by: Daniel McKnight <34697904+NeonDaniel@users.noreply.github.com>
@mikejgray mikejgray mentioned this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCP - portal
2 participants