Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] skill_resource_tests using incompatible version of neon_minerva #70

Closed
mikejgray opened this issue Jan 16, 2024 · 3 comments · Fixed by OpenVoiceOS/ovos-skill-easter-eggs#39
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@mikejgray
Copy link
Contributor

Description

https://github.com/OpenVoiceOS/ovos-skill-easter-eggs/actions/runs/7536978652/job/20515205017?pr=35

FAILED action/github/test/test_skill_resources.py::TestSkillResources::test_skill_setup - AttributeError: 'EasterEggsSkill' object has no attribute '_core_lang'. Did you mean: 'core_lang'?

Steps to Reproduce

  skill_resource_tests:
    uses: neongeckocom/.github/.github/workflows/skill_test_resources.yml@master

Relevant Code

No response

Other Notes

No response

@NeonDaniel
Copy link
Member

This should be resolved in v0.2.0 by NeonGeckoCom/neon-minerva#15

@NeonDaniel NeonDaniel self-assigned this May 15, 2024
@NeonDaniel NeonDaniel moved this to In Progress in Community Projects May 15, 2024
@NeonDaniel
Copy link
Member

@mikejgray can you confirm or recommend a method for me to confirm this is resolved?

@NeonDaniel NeonDaniel added the question Further information is requested label May 16, 2024
@mikejgray
Copy link
Contributor Author

@NeonDaniel Looks like I took Minerva out of the mix entirely in the repo where I originally reported this: https://github.com/OpenVoiceOS/ovos-skill-easter-eggs/blob/dev/test/test_skill.py

I think to test/replicate you'd use Minerva tests in an OVOSSkill skill. Not sure when I'll have a chance to check this out again. Most of my OVOSSkill-based stuff is off Minerva now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
Development

Successfully merging a pull request may close this issue.

2 participants