update imports #30
Merged
update imports #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove invalid license header, boilerplate copy paste from ancient times I'm the original author, in case of doubt the GPL license in header does not apply
mikejgray
reviewed
Dec 30, 2023
Comment on lines
+2
to
+3
| ovos-utils~=0.0, >=0.0.38 | ||
| ovos_workshop~=0.0, >=0.0.15 |
There was a problem hiding this comment.
I'd like to hold off on merging this until we've had a chance to bake in these updates for a few days.
There was a problem hiding this comment.
these are the latest stable versions, and the minimum versions for the refactored imports
from ovos_workshop.intents import IntentBuilder <-
There was a problem hiding this comment.
It's a holiday weekend for a lot of people and I don't think they're eager to have to fix their assistant because a skill dragged a new dependency
There was a problem hiding this comment.
also note without this the skill wont work with ovos-utils 0.1.0 (core is pinning 0.0.38)
but utils will just log deprecation warnings until then, skill keeps working, this is not critical
mikejgray
approved these changes
Jan 13, 2024
Merged
mikejgray
added a commit
that referenced
this pull request
Jul 18, 2024
* Increment Version * fix: correction to version.py * fix: release automation (#20) * fix: release automation * fix: setup looks for correct version * fix: adjust version location * Increment Version to * Update Changelog * chore: versioning * Increment Version to * Update Changelog * version * Increment Version to * Update Changelog * Increment Version to * fix: alpha release flow * Increment Version to 0.1.2a1 * Update Changelog * chore: Make README.md examples fit typical style (#22) The prior copy looked out of place in the rest of the homescreen examples, which are all capitalized and end in punctuation. * Update skill.json * more stt mistranscriptions for DukeNukemKeyword.voc (#26) * Increment Version to 0.1.2a2 * Update Changelog * update imports (#30) * update imports remove invalid license header, boilerplate copy paste from ancient times I'm the original author, in case of doubt the GPL license in header does not apply * Update skill.json --------- Co-authored-by: JarbasAl <JarbasAl@users.noreply.github.com> * Increment Version to 0.1.2a3 * Update Changelog * chore: standardize naming, move files to locale dir (#32) * chore: standardize naming, move files to locale dir * Increment Version to 0.1.2a4 * Update Changelog * feat: portal ocp (#35) * tests * feat: glados mp3s to OCP playback * use OCP API, stub and start writing tests * Update skill.json * rename unit test file * broader coverage * syntax * remove 3.12 tests resolves ModuleNotFoundError: No module named 'setuptools' * remove errant todo * remove unsupported use case * remove confusing and unnecessary section from README * Update skill.json --------- Co-authored-by: mikejgray <mikejgray@users.noreply.github.com> * Increment Version to 0.1.2a5 * Update Changelog * feat: best in life (#34) * feat: what is best in life? * tests * add resources * drop explicit 3.7 support Since this isn't a default skill anywhere, users must install it explicitly, so maintaining support for EOL Python doesn't make a ton of sense. Plus it's making the tests fail. * Increment Version to 0.1.2a6 * Update Changelog * feat: malibu stacey and bill and ted easter eggs (#37) * feat: malibu stacey and bill and ted easter eggs Addresses #28 * bump minerva version to ovos-workshop compat * remove copyrighted sounds * Increment Version to 0.1.2a7 * Update Changelog * automations/translations * translations/allow_UNUSED_keywords * Increment Version to 0.1.2a8 * Update Changelog * Re-enable intent tests (#39) * Update skill.json * feat: singing (#40) * feat: singing skill port Closes #2 * feat: container support If the environment variable is set indicating OVOS is running in a container, pass the GitHub URL of the file to OCP instead of the local URL. Naturally only works if the assistant has an internet connection to GitHub. Co-authored-by: mikejgray <mikejgray@users.noreply.github.com> * Increment Version to 0.1.2a9 * Update Changelog * feat: make it snow (#33) * feat: snow on Christmas * Increment Version to 0.1.2a10 * Update Changelog * fix: laws of robotics (#43) * fix: laws of robotics Only one law at a time when requesting a specific law * Increment Version to 0.1.2a11 * Update Changelog * Increment Version to 1.0.0 --------- Co-authored-by: mikejgray <mikejgray@users.noreply.github.com> Co-authored-by: Mike Gray <mike@graywind.org> Co-authored-by: AJ Jordan <alex@strugee.net> Co-authored-by: JarbasAI <33701864+JarbasAl@users.noreply.github.com> Co-authored-by: JarbasAl <JarbasAl@users.noreply.github.com> Co-authored-by: miro <jarbasai@mailfence.com> Co-authored-by: Daniel McKnight <34697904+NeonDaniel@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update imports for latest stable releases
remove invalid license header, boilerplate copy paste from ancient times
I'm the original author, in case of doubt the GPL license in header does not apply