Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all pom.xml as the template #436

Closed
gkwan-ibm opened this issue May 4, 2020 · 3 comments
Closed

Update all pom.xml as the template #436

gkwan-ibm opened this issue May 4, 2020 · 3 comments

Comments

@gkwan-ibm
Copy link
Member

gkwan-ibm commented May 4, 2020

  1. Remove the following properties and specify the version at the plugin directly:
        <!-- Plugin versions -->
        <version.liberty-maven-plugin>3.2</version.liberty-maven-plugin>
        <version.maven-failsafe-plugin>2.22.2</version.maven-failsafe-plugin>
        <version.maven-war-plugin>3.2.3</version.maven-war-plugin>
        <version.maven-surefire-plugin>2.22.2</version.maven-surefire-plugin>
  1. remove <failOnMissingWebXml>false</failOnMissingWebXml>

  2. Update dependencies to include following as the best practice:

    <!-- Provided dependencies -->
    <dependency>
      <groupId>jakarta.platform</groupId>
      <artifactId>jakarta.jakartaee-api</artifactId>
      <version>8.0.0</version>
      <scope>provided</scope>
    </dependency>
    <dependency>
      <groupId>org.eclipse.microprofile</groupId>
      <artifactId>microprofile</artifactId>
      <version>3.3</version>
      <type>pom</type>
      <scope>provided</scope>
    </dependency>
  1. If the pom.xml includes the following similar dependency, remove it, since it will be replaced with the aforementioned jakarta dependency:
        <dependency>
            <groupId>jakarta.platform</groupId>
            <artifactId>jakarta.jakartaee-web-api</artifactId>
            <version>8.0.0</version>
            <scope>provided</scope>
        </dependency>
  1. Once you made a PR to qa, make a PR to update the automation script here to reflect the new pom changes

  2. Create a card on the Wekan board with the two PRs

@gkwan-ibm
Copy link
Member Author

gkwan-ibm commented May 4, 2020

Pending

@MaiHameed
Copy link
Member

Once the changes are live, we'll need to update the automation scripts to reflect the changes to the pom.

@TiagoF99
Copy link

For (2) in this issue, refer to #446 for repositories that were pushed to master but overlooked it

@jj-zhang jj-zhang self-assigned this May 13, 2020
@salmad3 salmad3 self-assigned this May 14, 2020
AustinSeto pushed a commit to OpenLiberty/guide-microprofile-opentracing that referenced this issue Jan 5, 2021
gkwan-ibm added a commit to OpenLiberty/guide-microprofile-opentracing that referenced this issue Jan 8, 2021
* daily build and refactoring

* changed to executable

* removed dockfile sed

* changed to executable

* Sed fix

* Fix sed command

* Remove `<failOnMissingWebXml>` (see OpenLiberty/guides-common#436)

* Update test.yml

Co-authored-by: Gilbert Kwan <gkwan@ca.ibm.com>
Co-authored-by: Austin Seto <austin.seto@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants