Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Content Review 3 #2

Closed
3 tasks done
gkwan-ibm opened this issue May 5, 2020 · 1 comment
Closed
3 tasks done

Dev Content Review 3 #2

gkwan-ibm opened this issue May 5, 2020 · 1 comment
Assignees

Comments

@gkwan-ibm
Copy link
Member

gkwan-ibm commented May 5, 2020

  • Creating the system microservice
    • Beacuse to use create instead of replace, add 1 statement paragraph in between the paragraphs "The system microservice contains a method named sendProperty..." and "The messages are transported between ..."
      • "The [hotspot the whole method]sendSystemLoad() method calculates and publishes events that contains current average system load."
  • Creating the inventory microservice
    • need "...and adds it to the FlowableEmitter. " -> "...and adds it to the FlowableEmitter named property. " ??
      • need to let readers know the property is the emitter
  • Update Dockerfile to use openliberty/open-liberty:kernel-java8-openj9-ubi
@gkwan-ibm
Copy link
Member Author

gkwan-ibm commented May 6, 2020

@ankitagrawa

  • update the Dockerfiles
    • org.opencontainers.image.source to right url for this guide
    • summary for the name of this guide
  • update index.html
  • models/pom.xml
    • jakarta.jakartaee-web-api -> jakarta.jakartaee-api
    • add mp 3.3. dependency although not necessary but it is best practice of dev work flow template
  • sytem and inventory pom.xml
  • no need to have assets/.gitkeep
  • add test case for adding property into system and inventory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants