Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated pom #75

Merged
merged 6 commits into from
May 11, 2020
Merged

Updated pom #75

merged 6 commits into from
May 11, 2020

Conversation

griffinhadfield
Copy link

Updated the pom for the following issues:
OpenLiberty/guides-common#436
OpenLiberty/guides-common#419

TiagoF99
TiagoF99 suggested changes May 8, 2020
View reviewed changes
Copy link

@TiagoF99 TiagoF99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • update ${version.hazelcast} in places like this in pom.xml:<liberty.var.hazelcast.lib>${hazelcast.path}/${version.hazelcast}/hazelcast${version.hazelcast}.jar</liberty.var.hazelcast.lib>

  • add the link to your pr here:
    Update all pom.xml as the template guides-common#436

@gkwan-ibm gkwan-ibm mentioned this pull request May 8, 2020
Closed
@griffinhadfield
Copy link
Author

griffinhadfield commented May 8, 2020 •
edited
Loading

I should probably start using Ctrl F!
Fixed.

TiagoF99
TiagoF99 approved these changes May 11, 2020
View reviewed changes
Copy link

@TiagoF99 TiagoF99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

gkwan-ibm
gkwan-ibm requested changes May 11, 2020
View reviewed changes
Copy link
Member

@gkwan-ibm gkwan-ibm left a comment •
edited by griffinhadfield
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@griffinhadfield

  • remove <failOnMissingWebXml>false</failOnMissingWebXml> from the pom.xml

TiagoF99
TiagoF99 approved these changes May 11, 2020
View reviewed changes
Copy link

@TiagoF99 TiagoF99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gkwan-ibm gkwan-ibm merged commit aa066f2 into qa May 11, 2020
@AustinSeto
Copy link
Contributor

AustinSeto commented May 12, 2020 •
edited
Loading

Having trouble running from finish directory. Results in an internal server error, exception when retrieving session context when executing maven command.

To my understanding, should be able to run application from finish directory as described starting in the guide section "Running the Application".

EDIT: Found was related to OpenLiberty/open-liberty#12143

@AustinSeto
Copy link
Contributor

Cause of previous issue found. This change should be good for master now.

@gkwan-ibm gkwan-ibm mentioned this pull request May 12, 2020
Merged
@gkwan-ibm gkwan-ibm deleted the update-pom branch May 29, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiagoF99 TiagoF99 TiagoF99 approved these changes

@gkwan-ibm gkwan-ibm gkwan-ibm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@griffinhadfield @AustinSeto @gkwan-ibm @TiagoF99