Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elm] Add support for additionalProperties (map/hash/dictionary) #1262

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

eriktim
Copy link
Contributor

@eriktim eriktim commented Oct 17, 2018

Fixes #1140.

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Add support for additionalProperties

@eriktim eriktim mentioned this pull request Oct 17, 2018
8 tasks
@wing328 wing328 added this to the 3.3.2 milestone Oct 18, 2018
@eriktim
Copy link
Contributor Author

eriktim commented Oct 22, 2018

@wing328 updated as discussed

@wing328
Copy link
Member

wing328 commented Oct 23, 2018

@trenneman thanks. The change looks good to me.

As discussed the top level "additionalProperties" should be treated as an alias instead of a separate model. We'll address that in a separate PR.

@wing328 wing328 merged commit e782001 into OpenAPITools:master Oct 23, 2018
@eriktim eriktim deleted the elm-additionalproperties branch October 23, 2018 09:02
@wing328 wing328 changed the title [elm] Add support for additionalProperties [elm] Add support for additionalProperties (map/hash/dictionary) Oct 31, 2018
@andys8
Copy link
Contributor

andys8 commented Nov 14, 2018

Tested it, looking good :)

Is there documentation somewhere to know that --additional-properties elmPrefixCustomTypeVariants=true exists?

@eriktim
Copy link
Contributor Author

eriktim commented Nov 14, 2018

Have a look at https://github.com/OpenAPITools/openapi-generator/blob/master/docs/generators/elm.md or the other generators in that directory.

@andys8
Copy link
Contributor

andys8 commented Nov 14, 2018

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants