-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[elm] Process additionalProperties in parent alias when using composition (allOf) #1465
Labels
Milestone
Comments
@wing328 @trenneman would you mind taking a look at this? |
@wing328 Am I correct to say this is a general issue? I'd actually prefer to have the alias |
4 tasks
@trenneman yup, it should be fixed by #1296 |
mxinden
added a commit
to mxinden/alertmanager
that referenced
this issue
Nov 28, 2018
With issue 1465 on openapi-generator [1] being fixed, we can not extract shared properties of the gettable and postable alert definition into a shared object (`alert`) like we do for silence, gettable silence and postable silence. In addition this patch does the following changes to the UI: - Use `List GettableAlert` instead of plural type definition like `GettableAlerts` because the plural definitions are not generated. - Fix openapi-generator-cli docker image to specific hash. [1] OpenAPITools/openapi-generator#1465 Signed-off-by: Max Leonard Inden <IndenML@gmail.com>
mxinden
added a commit
to mxinden/alertmanager
that referenced
this issue
Nov 28, 2018
With issue 1465 on openapi-generator [1] being fixed, we can not extract shared properties of the gettable and postable alert definition into a shared object (`alert`) like we do for silence, gettable silence and postable silence. In addition this patch does the following changes to the UI: - Use `List GettableAlert` instead of plural type definition like `GettableAlerts` because the plural definitions are not generated. - Fix openapi-generator-cli docker image to specific hash. [1] OpenAPITools/openapi-generator#1465 Signed-off-by: Max Leonard Inden <IndenML@gmail.com>
This is fixed with #1296! Thanks a lot for the help @wing328 and @trenneman. Fix further downstream in Alertmanager: prometheus/alertmanager#1640. |
mxinden
added a commit
to mxinden/alertmanager
that referenced
this issue
Nov 28, 2018
With issue 1465 on openapi-generator [1] being fixed, we can not extract shared properties of the gettable and postable alert definition into a shared object (`alert`) like we do for silence, gettable silence and postable silence. In addition this patch does the following changes to the UI: - Use `List GettableAlert` instead of plural type definition like `GettableAlerts` because the plural definitions are not generated. - Fix openapi-generator-cli docker image to specific hash. [1] OpenAPITools/openapi-generator#1465 Signed-off-by: Max Leonard Inden <IndenML@gmail.com>
This was referenced Jul 31, 2022
This was referenced Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This is a follow up to #1140 and #1262.
When I use the allOf keyword to compose
GettableAlert
based onAlert
, theAnnotation
is not defined as aDict String String
but as aLabelSet
. But as discussed in #1140LabelSet
is not properly generated.openapi-generator version
3.3.4-SNAPSHOT
OpenAPI declaration file content or url
Command line used for generation
docker run --user=$(id -u ${USER}):$(id -g ${USER}) --rm -v ${PWD}:/local openapitools/openapi-generator-cli:latest generate -i /local/openapi.yaml -g elm -o /local/example
Steps to reproduce
Run above docker command with the above written OpenAPI specification. This results in:
Related issues/PRs
#1140 and #1262
The text was updated successfully, but these errors were encountered: