Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Elm OAS3 CI tests #1144

Closed
wants to merge 2 commits into from
Closed

Conversation

eriktim
Copy link
Contributor

@eriktim eriktim commented Sep 29, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master (3.3.x), 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Add OAS3 integration tests for Elm. (Follow-up on #1104.)

  • Escape special characters
  • Support additionalProperties
  • Support arrays of arrays
  • Support duplicate enum values

@eriktim eriktim removed this from the 3.3.0 milestone Oct 1, 2018
@mxinden
Copy link
Contributor

mxinden commented Oct 17, 2018

@trenneman what is the timeline for "Support additionalProperties"? This is a blocker for us in prometheus/alertmanager#1560 to use the openapi-generator project. Can I be of any help?

@eriktim
Copy link
Contributor Author

eriktim commented Oct 17, 2018

Hi @mxinden
I had hoped to fix it in this PR, but getting this one done is a bit more complex than I anticipated. I will start working on a new PR for the additionalProperties first. Will come with an ETA once I've got a feeling on the work that needs to be done. See #1262.

@wing328
Copy link
Member

wing328 commented Oct 17, 2019

@eriktim this PR has been opened for too long. Closing it for the time being. Please feel free to open a new one or reopen this one when it's ready for review.

@wing328 wing328 closed this Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants