Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use url.ParseRequestURI instead of url.Parse where appropriate #2796

Closed
4 tasks
pinebit opened this issue Jan 17, 2024 · 1 comment
Closed
4 tasks

Use url.ParseRequestURI instead of url.Parse where appropriate #2796

pinebit opened this issue Jan 17, 2024 · 1 comment
Assignees
Labels
good first issue Good for newcomers protocol Protocol Team tickets

Comments

@pinebit
Copy link
Contributor

pinebit commented Jan 17, 2024

🎯 Problem to be solved

In many places we use url.Parse which does not return an error if a given URL has no scheme prefix. We want to verify important URLs that they are well-formed URL strings including the scheme.

Original discussion

🛠️ Proposed solution

  • Revisit all url.Parse instances and replace with url.ParseRequestURI where appropriate.

🧪 Tests

  • Make sure all the affected tests are also updated and passed.
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@pinebit pinebit added the protocol Protocol Team tickets label Jan 17, 2024
@pinebit pinebit added the good first issue Good for newcomers label Jan 26, 2024
@pinebit pinebit self-assigned this Jan 26, 2024
obol-bulldozer bot pushed a commit that referenced this issue Jan 29, 2024
Replacing `url.Parse` with `url.ParseRequestURI` where appropriate. 

category: refactor
ticket: #2796
@pinebit
Copy link
Contributor Author

pinebit commented Jan 29, 2024

Fixed

@pinebit pinebit closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

1 participant