core: using url.ParseRequestURI
#2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2832 +/- ##
==========================================
- Coverage 53.22% 53.16% -0.06%
==========================================
Files 200 200
Lines 27705 27705
==========================================
- Hits 14745 14730 -15
- Misses 11131 11143 +12
- Partials 1829 1832 +3 ☔ View full report in Codecov by Sentry. |
dB2510
approved these changes
Jan 29, 2024
gsora
reviewed
Jan 29, 2024
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func MustParseURL(t *testing.T, rawURL string) *url.URL { |
There was a problem hiding this comment.
Why wrap both Parse and ParseRequestURI?
There was a problem hiding this comment.
Depends on the tests. Some rely on url.Parse while some on url.ParseRequestURI.
pinebit
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
url.Parsewithurl.ParseRequestURIwhere appropriate.category: refactor
ticket: #2796